Grib Enhancements

[rgleason]

Rick...
You can try, but remeber that you have to build the plugin against the old core codebase to give it a chance to run with the old versions. We are just forward binary compatible, not backward...
Pavel

1. A grib_pi.dll compiled under 3.3.1117 [most recent code] copied to the plugins directory in Opencpn 3.2.0 does not show in settings -> plugins and will not work.


2. With github opencpn/opencpn set on branch "Opencpn 3.0.2" and on local
repository. When I copy the recent grib_pi code to plugins and run cmake .. I have to copy plugins.Localization file to the plugins directory.

Then try cmake .. it runs ok. Then try cmake --build . and I get more errors.

CMake Error at plugins/grib_pi/CMakeLists.txt:161 (PLUGIN_LOCALIZATION):
  Unknown CMake command "PLUGIN_LOCALIZATION".


-- Configuring incomplete, errors occurred!

C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin>cmake ..
-- *** Build Architecture is i386
-- *** Staging to build opencpn 3.0.2 ***
-- Found OpenGL...
--     Lib: glu32opengl32
--     Include:
--
-- *** Staging to build opencpn  ***
-- *** Will install to C:/Program Files (x86)/OpenCPN  ***
-- GTK2 Not found...
-- tinyxml library not found
-- S57 ENC support: enabled
-- Garmin Host Mode support: enabled
--
-- *** Staging to build PlugIns ***
--
-- *** Staging to build dashboard_pi ***
-- *** Staging to build grib_pi ***
-- Writing spec file...
-- Configuring done
-- Generating done
-- Build files have been written to: C:/Users/Rick/Documents/GitHub/OpenCPN/buil
dwin

C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin>cmake --build .
Microsoft (R) Build Engine version 4.0.30319.17929
[Microsoft .NET Framework, version 4.0.30319.18052]
Copyright (C) Microsoft Corporation. All rights reserved.

Build started 12/5/2013 7:55:46 AM.
Project "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\ALL_BUILD.vcxproj" on n
ode 1 (default targets).
Project "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\ALL_BUILD.vcxproj" (1)
is building "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\GARMINHOST.vcxproj"
 (2) on node 1 (default targets).
Project "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\GARMINHOST.vcxproj" (2)
 is building "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\ZERO_CHECK.vcxproj
" (3) on node 1 (default targets).
InitializeBuildStatus:
  Creating "Win32\Debug\ZERO_CHECK\ZERO_CHECK.unsuccessfulbuild" because "Always
Create" was specified.
FinalizeBuildStatus:
  Deleting file "Win32\Debug\ZERO_CHECK\ZERO_CHECK.unsuccessfulbuild".
  Touching "Win32\Debug\ZERO_CHECK\ZERO_CHECK.lastbuildstate".
Done Building Project "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\ZERO_CHEC
K.vcxproj" (default targets).
InitializeBuildStatus:
  Creating "GARMINHOST.dir\Debug\GARMINHOST.unsuccessfulbuild" because "AlwaysCr
eate" was specified.
CustomBuild:
  All outputs are up-to-date.
ClCompile:
  All outputs are up-to-date.
  All outputs are up-to-date.
Lib:
  All outputs are up-to-date.
  GARMINHOST.vcxproj -> C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\Debug\GA
RMINHOST.lib
FinalizeBuildStatus:
  Deleting file "GARMINHOST.dir\Debug\GARMINHOST.unsuccessfulbuild".
  Touching "GARMINHOST.dir\Debug\GARMINHOST.lastbuildstate".
Done Building Project "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\GARMINHOS
T.vcxproj" (default targets).
Project "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\ALL_BUILD.vcxproj" (1)
is building "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\plugins\grib_pi\LIB
_BZIP.vcxproj" (4) on node 1 (default targets).
InitializeBuildStatus:
  Creating "LIB_BZIP.dir\Debug\LIB_BZIP.unsuccessfulbuild" because "AlwaysCreate
" was specified.
CustomBuild:
  All outputs are up-to-date.
ClCompile:
  All outputs are up-to-date.
Lib:
  All outputs are up-to-date.
  LIB_BZIP.vcxproj -> C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\plugins\gr
ib_pi\Debug\LIB_BZIP.lib
FinalizeBuildStatus:
  Deleting file "LIB_BZIP.dir\Debug\LIB_BZIP.unsuccessfulbuild".
  Touching "LIB_BZIP.dir\Debug\LIB_BZIP.lastbuildstate".
Done Building Project "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\plugins\g
rib_pi\LIB_BZIP.vcxproj" (default targets).
Project "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\ALL_BUILD.vcxproj" (1)
is building "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\NMEA0183.vcxproj" (
5) on node 1 (default targets).
InitializeBuildStatus:
  Creating "NMEA0183.dir\Debug\NMEA0183.unsuccessfulbuild" because "AlwaysCreate
" was specified.
CustomBuild:
  All outputs are up-to-date.
ClCompile:
  All outputs are up-to-date.
Lib:
  All outputs are up-to-date.
  NMEA0183.vcxproj -> C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\Debug\NMEA
0183.lib
FinalizeBuildStatus:
  Deleting file "NMEA0183.dir\Debug\NMEA0183.unsuccessfulbuild".
  Touching "NMEA0183.dir\Debug\NMEA0183.lastbuildstate".
Done Building Project "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\NMEA0183.
vcxproj" (default targets).
Project "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\ALL_BUILD.vcxproj" (1)
is building "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\S57ENC.vcxproj" (6)
 on node 1 (default targets).
InitializeBuildStatus:
  Creating "S57ENC.dir\Debug\S57ENC.unsuccessfulbuild" because "AlwaysCreate" wa
s specified.
CustomBuild:
  All outputs are up-to-date.
ClCompile:
  All outputs are up-to-date.
  All outputs are up-to-date.
Lib:
  All outputs are up-to-date.
  S57ENC.vcxproj -> C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\Debug\S57ENC
.lib
FinalizeBuildStatus:
  Deleting file "S57ENC.dir\Debug\S57ENC.unsuccessfulbuild".
  Touching "S57ENC.dir\Debug\S57ENC.lastbuildstate".
Done Building Project "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\S57ENC.vc
xproj" (default targets).
Project "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\ALL_BUILD.vcxproj" (1)
is building "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\plugins\dashboard_p
i\dashboard_pi.vcxproj" (7) on node 1 (default targets).
Project "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\plugins\dashboard_pi\da
shboard_pi.vcxproj" (7) is building "C:\Users\Rick\Documents\GitHub\OpenCPN\buil
dwin\plugins\dashboard_pi\dashboard-i18n.vcxproj" (8) on node 1 (default targets
).
InitializeBuildStatus:
  Creating "Win32\Debug\dashboard-i18n\dashboard-i18n.unsuccessfulbuild" because
 "AlwaysCreate" was specified.
CustomBuild:
  dashboard-i18n: Done.
FinalizeBuildStatus:
  Deleting file "Win32\Debug\dashboard-i18n\dashboard-i18n.unsuccessfulbuild".
  Touching "Win32\Debug\dashboard-i18n\dashboard-i18n.lastbuildstate".
Done Building Project "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\plugins\d
ashboard_pi\dashboard-i18n.vcxproj" (default targets).
Project "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\plugins\dashboard_pi\da
shboard_pi.vcxproj" (7) is building "C:\Users\Rick\Documents\GitHub\OpenCPN\buil
dwin\opencpn.vcxproj" (9) on node 1 (default targets).
Project "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\opencpn.vcxproj" (9) is
 building "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\i18n.vcxproj" (10) on
 node 1 (default targets).
InitializeBuildStatus:
  Creating "Win32\Debug\i18n\i18n.unsuccessfulbuild" because "AlwaysCreate" was
specified.
CustomBuild:
  i18n: Done.
FinalizeBuildStatus:
  Deleting file "Win32\Debug\i18n\i18n.unsuccessfulbuild".
  Touching "Win32\Debug\i18n\i18n.lastbuildstate".
Done Building Project "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\i18n.vcxp
roj" (default targets).
InitializeBuildStatus:
  Creating "opencpn.dir\Debug\opencpn.unsuccessfulbuild" because "AlwaysCreate"
was specified.
CustomBuild:
  All outputs are up-to-date.
ClCompile:
  All outputs are up-to-date.
  All outputs are up-to-date.
ResourceCompile:
  All outputs are up-to-date.
ManifestResourceCompile:
  All outputs are up-to-date.
Link:
  All outputs are up-to-date.
Manifest:
  All outputs are up-to-date.
FinalizeBuildStatus:
  Deleting file "opencpn.dir\Debug\opencpn.unsuccessfulbuild".
  Touching "opencpn.dir\Debug\opencpn.lastbuildstate".
Done Building Project "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\opencpn.v
cxproj" (default targets).
InitializeBuildStatus:
  Creating "dashboard_pi.dir\Debug\dashboard_pi.unsuccessfulbuild" because "Alwa
ysCreate" was specified.
CustomBuild:
  All outputs are up-to-date.
ClCompile:
  All outputs are up-to-date.
ManifestResourceCompile:
  All outputs are up-to-date.
Link:
  All outputs are up-to-date.
Manifest:
  All outputs are up-to-date.
FinalizeBuildStatus:
  Deleting file "dashboard_pi.dir\Debug\dashboard_pi.unsuccessfulbuild".
  Touching "dashboard_pi.dir\Debug\dashboard_pi.lastbuildstate".
Done Building Project "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\plugins\d
ashboard_pi\dashboard_pi.vcxproj" (default targets).
Project "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\ALL_BUILD.vcxproj" (1)
is building "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\plugins\grib_pi\gri
b_pi.vcxproj" (11) on node 1 (default targets).
Project "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\plugins\grib_pi\grib_pi
.vcxproj" (11) is building "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\plug
ins\grib_pi\grib-i18n.vcxproj" (12) on node 1 (default targets).
InitializeBuildStatus:
  Creating "Win32\Debug\grib-i18n\grib-i18n.unsuccessfulbuild" because "AlwaysCr
eate" was specified.
CustomBuild:
  grib-i18n [hu]: Created mo file.
  grib_pi-i18n: Done.
FinalizeBuildStatus:
  Deleting file "Win32\Debug\grib-i18n\grib-i18n.unsuccessfulbuild".
  Touching "Win32\Debug\grib-i18n\grib-i18n.lastbuildstate".
Done Building Project "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\plugins\g
rib_pi\grib-i18n.vcxproj" (default targets).
InitializeBuildStatus:
  Touching "grib_pi.dir\Debug\grib_pi.unsuccessfulbuild".
CustomBuild:
  All outputs are up-to-date.
ClCompile:
  c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\bin\CL.exe /c /I"C:/wxW
idgets-2.8.12/lib/vc_dll/mswu" /I"C:/wxWidgets-2.8.12/include" /IC:/Users/Rick/D
ocuments/GitHub/OpenCPN/include /IC:/Users/Rick/Documents/GitHub/OpenCPN/src /IC
:/Users/Rick/Documents/GitHub/OpenCPN/src/nmea0183 /IC:/Users/Rick/Documents/Git
Hub/OpenCPN/src/mygdal /IC:/Users/Rick/Documents/GitHub/OpenCPN/src/garmin/jeeps
 /I"C:/Users/Rick/Documents/GitHub/OpenCPN/plugins/grib_pi/./src/zlib-1.2.3" /IC
:/Users/Rick/Documents/GitHub/OpenCPN/plugins/grib_pi/./src/bzip2 /Zi /nologo /W
3 /WX- /Od /Ob0 /Oy- /D WIN32 /D _WINDOWS /D _DEBUG /D WXUSINGDLL /D UNICODE /D
_UNICODE /D USE_GLU_TESS /D __MSVC__ /D _CRT_NONSTDC_NO_DEPRECATE /D _CRT_SECURE
_NO_DEPRECATE /D PSAPI_VERSION=1 /D TIXML_USE_STL /D USE_S57 /D USE_GARMINHOST /
D __WIN32__ /D __MSVC__ /D _CRT_NONSTDC_NO_DEPRECATE /D _CRT_SECURE_NO_DEPRECATE
 /D WXUSINGDLL /D UNICODE /D _UNICODE /D _DEBUG /D __WXDEBUG__ /D _DEBUG /D __WX
DEBUG__ /D "CMAKE_INTDIR=\"Debug\"" /D grib_pi_EXPORTS /D _WINDLL /D _UNICODE /D
 UNICODE /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /GR /Fo"
grib_pi.dir\Debug\\" /Fd"C:/Users/Rick/Documents/GitHub/OpenCPN/buildwin/plugins
/grib_pi/Debug/grib_pi.pdb" /Gd /TP /analyze- /errorReport:queue ..\..\..\plugin
s\grib_pi\src\GribOverlayFactory.cpp ..\..\..\plugins\grib_pi\src\GribUIDialogBa
se.cpp ..\..\..\plugins\grib_pi\src\GribUIDialog.cpp ..\..\..\plugins\grib_pi\sr
c\GribSettingsDialog.cpp ..\..\..\plugins\grib_pi\src\email.cpp ..\..\..\src\wxJ
SON\jsonval.cpp ..\..\..\src\wxJSON\jsonreader.cpp ..\..\..\src\wxJSON\jsonwrite
r.cpp ..\..\..\plugins\grib_pi\src\smapi.cpp  /Zm1000
  GribOverlayFactory.cpp
..\..\..\plugins\grib_pi\src\GribOverlayFactory.cpp(1016): error C3861: 'GetChar
tbarHeight': identifier not found [C:\Users\Rick\Documents\GitHub\OpenCPN\buildw
in\plugins\grib_pi\grib_pi.vcxproj]
  GribUIDialogBase.cpp
  GribUIDialog.cpp
  GribSettingsDialog.cpp
  email.cpp
  jsonval.cpp
  jsonreader.cpp
..\..\..\src\wxJSON\jsonreader.cpp(1853): error C2371: 'byte' : redefinition; di
fferent basic types [C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\plugins\gri
b_pi\grib_pi.vcxproj]
          c:\program files (x86)\microsoft sdks\windows\v7.0a\include\rpcndr.h(1
60) : see declaration of 'byte'
  jsonwriter.cpp
  smapi.cpp
  Generating Code...
c:\users\rick\documents\github\opencpn\plugins\grib_pi\src\smapi.cpp(217): warni
ng C4715: 'wxMapiSession::Logon' : not all control paths return a value [C:\User
s\Rick\Documents\GitHub\OpenCPN\buildwin\plugins\grib_pi\grib_pi.vcxproj]
Done Building Project "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\plugins\g
rib_pi\grib_pi.vcxproj" (default targets) -- FAILED.
Done Building Project "C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\ALL_BUILD
.vcxproj" (default targets) -- FAILED.

Build FAILED.

"C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\ALL_BUILD.vcxproj" (default tar
get) (1) ->
"C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\plugins\grib_pi\grib_pi.vcxproj
" (default target) (11) ->
(ClCompile target) ->
  c:\users\rick\documents\github\opencpn\plugins\grib_pi\src\smapi.cpp(217): war
ning C4715: 'wxMapiSession::Logon' : not all control paths return a value [C:\Us
ers\Rick\Documents\GitHub\OpenCPN\buildwin\plugins\grib_pi\grib_pi.vcxproj]


"C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\ALL_BUILD.vcxproj" (default tar
get) (1) ->
"C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\plugins\grib_pi\grib_pi.vcxproj
" (default target) (11) ->
(ClCompile target) ->
  ..\..\..\plugins\grib_pi\src\GribOverlayFactory.cpp(1016): error C3861: 'GetCh
artbarHeight': identifier not found [C:\Users\Rick\Documents\GitHub\OpenCPN\buil
dwin\plugins\grib_pi\grib_pi.vcxproj]
  ..\..\..\src\wxJSON\jsonreader.cpp(1853): error C2371: 'byte' : redefinition;
different basic types [C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin\plugins\g
rib_pi\grib_pi.vcxproj]

    1 Warning(s)
    2 Error(s)

Time Elapsed 00:00:15.34

C:\Users\Rick\Documents\GitHub\OpenCPN\buildwin>

Its pretty clear this is not simple, and the code has migrated somewhat.
Even though the Plugin API might be very early (Plugin API 1.7) other things in the code have changed so it will not compile under Opencpn 3.0.2

So, I think it is important to put the OV [OpenCPN Version} designation in the file name.

Also I am going to just move forward and not try to get grib_pi or other plugins running in earlier versions. Its just progress.

[rgleason]

C:\Data-Dart\Up-Soft\Navigation\opencpn-git>git pull
Already up-to-date.

C:\Data-Dart\Up-Soft\Navigation\opencpn-git>git branch -va
* master 8aafcca Fix an assert and subsequent crash on Mac OSX with wxWidgets 3.1
remotes/origin/HEAD -> origin/master

====

Most recent grib_pi.dll for use with Opencpn 3.3.1117
grib_win32_pi17_v22_ov331117_pi.dll

Opencpn Beta File thingie rguser rgpass
in this folder Home /Plugiins-Win-Opencpn-3.3.1117

[rgleason]

Code snippets for downloading files from internet
Download a file from internet - WxWiki

Download file using libcurl in C/C++ - Stack Overflow

c++ - How to download a file from a server? - Stack Overflow

https://www.google.com/search?q=c%2B...ient=firefox-a

[Baikal]

Little not that that I would like to see the data display Beaufort
You've read the comments and requests are FS # 993?

Wish was that it would add to the data of the wind field with additional information about Beaufort and the wave height of the table. I even drew a picture how it would look!

Then as now made ​​uncomfortable does not see both wind speed and Beaufort.

[rgleason]

Baikal. I am trying to understand. FS#993 was closed by Serge (the originator) because Beaufort was implemented. OpenCPN::Tracker All Projects: Tasklist

What is the problem/request, specifically? Where is your picture?

[Baikal]

Here is what was meant by the feature request to display data table Beaufort

[rgleason]

Baikal, Are you proposing to have Wind data use two rows like that all the time? Or is this intended to be an option in Peferences? Please elaborate more. Thanks.

[Baikal]

Originally Posted by rgleason

Baikal, Are you proposing to have Wind data use two rows like that all the time? Or is this intended to be an option in Peferences? Please elaborate more. Thanks.

second row (Beaufort Table) is activated in the plugin settings

[Baikal]

What decision was made according to data Beaufort?

[Ptizef]

I would propose something like that :

[rgleason]

Yes, I like that, this has my vote, Jean Pierre.
-With your suggestions and some trials I managed to make a pull request for weatherfax. Also it appears Mike [Rasbats] has a weather_routing_pi solution for the grib problem I was having. I need to do that next.
Thanks

[Baikal]

Originally Posted by Ptizef

I would propose something like that :

I like it, so let's leave

[rgleason]

Jean Pierre,
Will this change

Ptizef opened pull request OpenCPN/OpenCPN#83

Add double wind speed display (in current unit + beaufort) in the main d...

Eliminate the possibility of showing Wind - Speed with Direction ?
I hope not!

[AISEAG]

Originally Posted by Ptizef

I would propose something like that :

Hi Jean Pierre,

You get my vote

Serge

[rgleason]

Right... forgot it had kn bf and dir ... sorry.