RotationCtrl Plugin

[rgleason]

I am trying to compile Sean's new RotationCtrl plugin which seems to still have some errors when compiling with current v4.1 of opencpn.lib.

This plugin is a reasonable solution to issues we were having with the options interface during the final hours of issuing version 4.0.

Bdcat resolved the issues by removing the option of rotating charts, which was a reasonable call at the time given that feature was not a high priority for many users.

However I believe it is a feature that could be very useful for some, provided it did does not confuse new users and logjam development.

To that end, Sean has made a RotationCtrl Plugin which was paired with an Opencpn pull request.

I have not been able to find Sean's pull request on github.com in either Sean's pull requests or under outstanding Opencpn repository pull requests (still learning). This leads me to believe that the pull request was merged but I have not found it yet.

1. Has Sean's pull request been merged with the current 4.1 Opencpn?
2. If so, I am getting this error when I compile rotationctrl with the current v4.1 opencpn.lib.

--It is possible I have overlooked something.

Build FAILED.

"C:\Data-Dart\Up-Soft\Navigation\o-plugin\rotationctrl_pi\build\ALL_BUILD.vcxproj" (default target) (1) ->
"C:\Data-Dart\Up-Soft\Navigation\o-plugin\rotationctrl_pi\build\rotationctrl_pi.vcxproj" (default target) (3) ->
(Link target) ->
  rotationctrl_pi.obj : error LNK2001: unresolved external symbol "public: virtual void __thiscall opencpn_plugin_113::OnToolbarToolDownCallback(int)" (?OnToolbarToolDownCallback@opencpn_plugin_113@@UAEXH@Z) [C:\Data-Dart\Up-Soft\Navigation\o-plugin\rotationctrl_pi\build\rotationctrl_pi.vcxproj]
  PreferencesDialog.obj : error LNK2001: unresolved external symbol "public: virtual void __thiscall opencpn_plugin_113::OnToolbarToolDownCallback(int)" (?OnToolbarToolDownCallback@opencpn_plugin_113@@UAEXH@Z) [C:\Data-Dart\Up-Soft\Navigation\o-plugin\rotationctrl_pi\build\rotationctrl_pi.vcxproj]
  rotationctrl_pi.obj : error LNK2001: unresolved external symbol "public: virtual void __thiscall opencpn_plugin_113::OnToolbarToolUpCallback(int)" (?OnToolbar
ToolUpCallback@opencpn_plugin_113@@UAEXH@Z) [C:\Data-Dart\Up-Soft\Navigation\o-plugin\rotationctrl_pi\build\rotationctrl_pi.vcxproj]
  PreferencesDialog.obj : error LNK2001: unresolved external symbol "public: virtual void __thiscall opencpn_plugin_113::OnToolbarToolUpCallback(int)" (?OnToolb
arToolUpCallback@opencpn_plugin_113@@UAEXH@Z) [C:\Data-Dart\Up-Soft\Navigation\o-plugin\rotationctrl_pi\build\rotationctrl_pi.vcxproj]
  rotationctrl_pi.obj : error LNK2019: unresolved external symbol "void __cdeclSetCanvasRotation(double)" (?SetCanvasRotation@@YAXN@Z) referenced in function "
public: virtual void __thiscall rotationctrl_pi::OnToolbarToolCallback(int)" (?OnToolbarToolCallback@rotationctrl_pi@@UAEXH@Z) [C:\Data-Dart\Up-Soft\Navigation\o-plugin\rotationctrl_pi\build\rotationctrl_pi.vcxproj]
  rotationctrl_pi.obj : error LNK2019: unresolved external symbol "bool__cdeclGetSingleWaypoint(class wxString &,class PlugIn_Waypoint *)" (?GetSingleWaypoint@@YA_NAAVwxString@@PAVPlugIn_Waypoint@@@Z) referenced in function "public: void__thiscall rotationctrl_pi::OnTimer(class wxTimerEvent &)" (?OnTimer@rotationctrl_pi@@QAEXAAVwxTimerEvent@@@Z) [C:\Data-Dart\Up-Soft\Navigation\o-plugin\rotationctrl_pi\build\rotationctrl_pi.vcxproj]
  C:\Data-Dart\Up-Soft\Navigation\o-plugin\rotationctrl_pi\build\Debug\rotationctrl_pi.dll : fatal error LNK1120: 4 unresolved externals [C:\Data-Dart\Up-Soft\Navigation\o-plugin\rotationctrl_pi\build\rotationctrl_pi.vcxproj]

    0 Warning(s)
    7 Error(s)

========

PS:
I just found Sean's pull request for Plugin API 1.13 here
https://github.com/OpenCPN/OpenCPN/pull/242
initial functions for plugin api 1.13 #242


I guess it has not been merged yet.

Correction: Sean closed the pull request, and it appears to have been "commited".

Does anyone have any suggestion to compile this?

[seandepagnier]

I had to rebase because of more changes.. basically pull requests go stale once changes get commited that conflict with them before they are merged.

https://github.com/OpenCPN/OpenCPN/pull/264

Otherwise you could just pull my opencpn repository and use that to test this plugin.

https://github.com/seandepagnier/OpenCPN

[rgleason]

The RotationCtrl_pi plugin has been updated again to improve heading.

https://github.com/rgleason/rotation...s/tag/v0.2.002

[rgleason]

Rotation Control improved by Sean to include Wind heading
https://github.com/rgleason/rotation...g/v0.4.000beta

[Ben S]

This plugin is not working in O5, no multiple canvas support.
Plugin icon is also not displayed correct.
I use it to stabelize the charts (and maybe later radar) to HDG
So if the boat is drifting for fishing, charts with waypoints don't turn around crazy.
But O5 only rotate's charts to COG.

Feature request for OpenCPN 5.x, add a 3the choice, North up, Course up, and Vessel Heading up please

[hoolie]

Originally Posted by Ben S

...

Feature request for OpenCPN 5.x, add a 3the choice, North up, Course up, and Vessel Heading up please

This has been discussed before - I can't find where. I seem to recall that Dave bdbcat has said it can't be done, though it seems a very useful feature even if you're not drifting about fishing. Heading up if heading is available, else course up if it's not

[bcn]

There is one more "waterway axis up". Particularly interesting for Inland waterways.

[rgleason]

Nice idea. Sean made a merge of PR on Pypilot 8 days ago. Try raising him on pypilot?

[Ben S]

Originally Posted by hoolie

This has been discussed before - I can't find where. I seem to recall that Dave bdbcat has said it can't be done, though it seems a very useful feature even if you're not drifting about fishing. Heading up if heading is available, else course up if it's not

In OpenCPN 4.8.x HDG up works perfect with rotation plugin.
So i think it is not so difficult to implement in O5

In a few months i go fishing in Denmark
Going to install version 4.8.8 on the boat so this works again with te plugin.

[bdbcat]

May we please have these issues entered in Flyspray bug tracker as Feature Requests, (or bugs if appropriate) so that they may not be forgotten?


Thanks
Dave

[seandepagnier]

I just tried the plugin and it seems to work, but only for the first canvas.

[Ben S]

Originally Posted by bdbcat

May we please have these issues entered in Flyspray bug tracker as Feature Requests, (or bugs if appropriate) so that they may not be forgotten?


Thanks
Dave

Can someone please enter this in flyspray
I cannot make an account

Completely unexpected exception: Failed to authenticate on SMTP server with username "opencpn@bigdumboat.com" using 2 possible authenticators
This should never happend, please inform Flyspray Developers

[rgleason]

Bens. Why cant you make an account? Registration should work.

[Ben S]

Originally Posted by rgleason

Bens. Why cant you make an account? Registration should work.

No, i always get "Completely unexpected exception" if i click to transmit the code.

[rgleason]

Dave, Maybe registration needs some kind of attention?