Attenuate Less Critical Targets

[rgleason]

Would someone please explain if this change has anything to do with
"Attenuate Less Critical Targets?"

Fix the real size AIS target display being scaled with the chart obje……cts - The size of the target has to always respect reality.

https://github.com/nohal/OpenCPN/com...fa07599a1ba24d
if (g_bDrawAISSize && bcan_draw_size)
{
dc.SetBrush( wxBrush( UBLCK, wxBRUSHSTYLE_TRANSPARENT ) );
- dc.StrokePolygon( 6, ais_real_size, TargetPoint.x, TargetPoint.y, scale_factor );
+ dc.StrokePolygon( 6, ais_real_size, TargetPoint.x, TargetPoint.y, 1.0 );


If so, I believe it should be undone.

[nohal]

Rick...
What is the problem you are seeing?

Thanks

Pavel

[rgleason]

Pavel,

I have not built and run the result of this, nor have I followed it in the code.

Rooie Dirk Dirk Smits created an AIS "declutter" feature which makes AIS Targets that meet certain specific parameters smaller. This was a reasonable response to many complaints about over cluttered screens in densely populated AIS areas.

You may not have seen the features development and Bdbcat's acceptance of the pull request.

Since the changes to code appear to remove scaling of AIS Target, I have asked about it.

PS:Maybe it is related to some efforts of did-g to make the AIS target "lines" write more clearly? - Brush?

[nohal]

Rick...
This patch has nothing to do with that, it fixes the real size of the vessels being scaled according to the chart object scaling setting, which is wrong - a 30m long vessel is simply 30m long, regardless of how big you want to see the chart objects.

Pavel

[rgleason]

Yes, of course that is right.
Thanks.

[rgleason]

After thinking about it further.. Of course real world objects have a scale of 1:1 to be shown properly. It is when text and symbols get involved that things get different.

There is a feature which allows increase of ownship size above 1:1. I assume this feature is not dependent on that variable value "scale_factor"

Sorry to bring it up again.