Beta Test / Technical

[Hakan]

Win10. VS2013

Since some of the commits after change to version 4.2.1 is the program icon not longer showed correct by Win10. I use the package installer.
Below pict. shows the new desktop icon and below that the icon from 4.2.0. (My portable OCPN instance copied from 4.2 2016-04-18)

[CarCode]

Commit "Correct Waypoint Properties Dialog icon drop-down list height (FS#2000)" of today (30.04.2016)

For Mac OS X the line "WX_DECLARE_LIST(wxBitmap, BitmapList);" should be in routeprop.h and not in routeprop.cpp.

Gerhard

[Douwe Fokkema]

Some functions of the br24radar_pi version1.32 plugin only work correctly with the latest version of OpenCPN/master. To be more specific: for the correct orientation of the boat symbol in radar-only mode and when passing a heading to OpenCPN, pull request #621 (merged) is needed.
For many of our users compiling OpenCPN is just too much. Is there already a planning for bringing out a next beta version of OpenCPN?

[bdbcat]

@CarCode...

re:
Commit "Correct Waypoint Properties Dialog icon drop-down list height (FS#2000)" of today (30.04.2016)

For Mac OS X the line "WX_DECLARE_LIST(wxBitmap, BitmapList);" should be in routeprop.h and not in routeprop.cpp.

I don't see any problem building from the current github master.
Do you?

Dave

[CarCode]

Originally Posted by bdbcat

@CarCode...

re:
Commit "Correct Waypoint Properties Dialog icon drop-down list height (FS#2000)" of today (30.04.2016)

For Mac OS X the line "WX_DECLARE_LIST(wxBitmap, BitmapList);" should be in routeprop.h and not in routeprop.cpp.

I don't see any problem building from the current github master.
Do you?

Dave

Yes, otherwise I don't wrote this.

Gerhard

[cagney]

Dave!
Testing the latest Git I get repeated crashes when handling mark properties.


/Thomas

[bdbcat]

@Carcode....

Maybe a little bit more detail would be useful.

Thanks
Dave

[bdbcat]

Thomas...

Do you crash always when showing the Mark Prop dialog, or only on some conditions?

Thanks
Dave

[CarCode]

Originally Posted by bdbcat

@Carcode....

Maybe a little bit more detail would be useful.

Thanks
Dave

Simply read the wxWidgets include files, yes, you find listimpl.cpp in the includes.
If "WX_DECLARE_LIST()" is in the *.cpp and not in *.h a smart compiler says "Called C++ object pointer is null".
There are several other such cases in the source.

Gerhard

[cagney]

Originally Posted by bdbcat

Thomas...

Do you crash always when showing the Mark Prop dialog, or only on some conditions?

Thanks
Dave

Dave
I see a crash in 75 to 80% of the cases, when handling properties and then change the icon selection. The crash comes, sometimes when opening the properties dialog, and sometimes when activating a new icon, in other words when pressing "OK".

/Thomas

[Hakan]

Thomas crash report confirmed:
Win10. VS2013. The code's last commit 0bb01aa......... "Correct Waypoint Properties Dialog icon drop-down list height (FS#2000)"

Method to reproduce the crash:
- Create a WP
- Left click the WP - Properties - give it a name - OK
- Open Route & Mark manager tool.
- Select tab Waypoints
- Select the created WP and open properties.
- Change icon - OK
- Select the WP again. - Click properties -> crash.
(If I not change the icon - no crash. Then the properties box can be opened and closed without problem)

Håkan

[bdbcat]

@Carcode...

Not to be too pedantic, but...

The only requirement is that the various macro definitions come in the following order within a single compiled module:

WX_DECLARE_LIST(wxBitmap, BitmapList);
#include <wx/listimpl.cpp>
WX_DEFINE_LIST(BitmapList);

The existence in or out of an include file is not relevant. In this case, since the list and its container class are not to be referenced outside of the instant compile module, the list declaration doesn't need to be in the include file at all.

If you have a real compile time or runtime failure related to this, lets see it.

Dave

[bdbcat]

Thomas/Hakan...

re:
Thomas crash report confirmed:
Win10. VS2013. The code's last commit 0bb01aa......... "Correct Waypoint Properties Dialog icon drop-down list height (FS#2000)"


Fault confirmed. Corrected in github now.

Thanks
Dave

[Hakan]

Dave..
Correction confirmed.
Thanks
Håkan

[CarCode]

Originally Posted by bdbcat

@Carcode...

Not to be too pedantic, but...

Dave

That is why I make my own version for OS X since a long time now.
BTW your date format changed in TCwin.cpp yesterday is wrong also.

Gerhard