Beta Test / Technical

[CarCode]

Originally Posted by boat_alexandra

Printing does not work for routes either for me. It produces a pdf file that is empty.

I guessed it already. You might have another OpenCPN version than others, so none of your submitted patches for the official version will work and must be reworked first.

Gerhard

[cagney]

Options->Charts->Chart Files ->Parse All ENC Charts

This option stops every time I try it. Mostly sig-aborted but sometimes a segfault.
4.5.0 , latest git master, Kubuntu 14.04 ,64 bits.



/Thomas

[ChuckSK]

Originally Posted by cagney

Options->Charts->Chart Files ->Parse All ENC Charts

This option stops every time I try it. Mostly sig-aborted but sometimes a segfault.
4.5.0 , latest git master, Kubuntu 14.04 ,64 bits.

Attachment 129970

/Thomas

I submitted a pull request #714 that should fix this.

chuck

[Hakan]

Toady's fetch from master
Win10, VS2013

I today received the below errors. My build two days ago was fine and I can't find any code changes explaining this????
(And I don't have any cairo.h in my ....\cario\ folder or elsewhere)

SVGCanvasCairo.cpp
1>c:\builds\ocpn\opencpn\src\wxsvg\src\cairo\SVGCanvasCairo.h(15): fatal error C1083: Cannot open include file: 'cairo/cairo.h': No such file or directory
1>  SVGCanvasImageCairo.cpp
1>c:\builds\ocpn\opencpn\src\wxsvg\src\cairo\SVGCanvasImageCairo.h(15): fatal error C1083: Cannot open include file: 'cairo/cairo.h': No such file or directory
1>  SVGCanvasPathCairo.cpp
1>c:\builds\ocpn\opencpn\src\wxsvg\src\cairo\SVGCanvasPathCairo.h(15): fatal error C1083: Cannot open include file: 'cairo/cairo.h': No such file or directory
1>  SVGCanvasTextCairo.cpp
1>c:\builds\ocpn\opencpn\src\wxsvg\src\cairo\SVGCanvasPathCairo.h(15): fatal error C1083: Cannot open include file: 'cairo/cairo.h': No such file or directory
1>  svgxml.cpp
1>C:\Builds\OCPN\OpenCPN\src\wxsvg\src\svgxml\svgxml.cpp(24): fatal error C1083: Cannot open include file: 'expat.h': No such file or directory

[bdbcat]

Hakan...

The cairo include files should be in something like:

C:\Builds\OCPN\opencpn\buildwin\gtk\include\cairo\cairo.h

Dave

[Hakan]

Dave
Yes, of course, I should have known. Wonder how they have disappeared?? I new copy of "OpenCPN_buildwin" fixed it all.
Thanks for your advise.
Håkan

[cagney]

Originally Posted by ChuckSK

I submitted a pull request #714 that should fix this.

chuck

Dave/Chuck

It looks like Dave has included your patch in the current master.
The immediate crash problem is gone.
The main problem now is that all ENCs are not parsed.
I have tried the button a few times and still encounter ENC-parsing.

/Thomas

[seandepagnier]

Are you claiming that you must click the button several times to parse all the charts?

[cagney]

Originally Posted by boat_alexandra

Are you claiming that you must click the button several times to parse all the charts?

I have clicked the button 3 or 4 times, but still encounters parsings.
As these parsings are fairly quick and short, it struck me that maybe O does not currently handle pending, already downloaded updates, to previosly parsed charts (cells)?
I know that I have many updates downloaded but not parsed, so that may
explain the parsing.

/Thomas

[P_Dub]

Maybe is time for a new beta!
Best Regard.

[bdbcat]

cagney...

Lets talk about the "Parse all ENCs" button (Which, btw, I have renamed "Prepare all ENCs")

The code currently creates new SENCs as needed, applying recent updates if discovered.

Of course, the logic needs to read part of the ENC .000 file to check the chart edition, and compare against the existing SENC, if any. But this should be very fast.

So if you press the button repeatedly, the process should be fast if the SENCs are up-to-date.

Are you seeing behaviour other than this?

Thanks
Dave

[cagney]

Dave

Testing again...
All ENCs for me, is equal to all US east coast ENCs including PR & Virgin Islands.
I have recently updated these charts through the downloader, but not used them since.

+Running Parse All, about 9 min.
+Pressing the same button again, without first pressing "Apply" => crash.
+Restarting. Testing ENCs. O is parsing updates(short quick parsings)
+Running Parse all again , about 10 min.
+ Testing ENCs, still parsing updates.
+Running parse all again. Pressed "Apply" and then parse all once again. No crash
+Trying to stop the parsing by pressing "Skip". Nothing happens. No visual pressed button. No interruption even when pressing the "x".
+Testing ENCs again after the updates finished. Still updating individual ENCs.

/Thomas

[bdbcat]

Thomas...

OK, thanks, I understand the scenario and test conditions.

I will shortly post a substantial patch with completely refactored ENC SENC format, new rendering logic, etc. Also some fixes to "Prepare all", which should fix these issues. I will test the new code now just as you are testing, to be sure the problems are corrected.

Thanks
Dave

[bdbcat]

cagney.

re:
I will shortly post a substantial patch with completely refactored ENC SENC format, new rendering logic, etc.

Done, in github now.

Beat it with a stick!

Thanks
Dave

[Hakan]

Dave..
On Win and VS2013:
All plugins and others disappeared from the build environment after the new commit.
Pls check cmakelist or what's controlling what's in the solution.