Beta Test / Technical

[RobTD]

Hi all,

Just quickly want to introduce myself. Rob, 33 from the Netherlands, sailing in a Dehler Sprinta.

Would like to try and help with OpenCPN development, because (1) I'm tired of all the closed-source 'water maps' and their problems, and would like to invest my energy in helping to improve an open-source solution and (2) want to get back into programming, after some years of 'rest'.

I am no guru at all, but I do have experience with C++, C, other languages, Linux/BSD/RPi, design&development, etc.

My plan is to follow Flyspray and Github Issues for a while, see if I can support tickets by testing, and slowly get familiar with some of the codebase.

Please do let me know if there are any concrete ways I can support some of you.

Thanks in advance,
Rob

[rgleason]

Welcome Rob. We do have a Dev Manual here which might help somewhat. Parts of it are not current and parts are under development, but there is a pretty strong section on Plugins and a number of "Beta" plugins too.
There are many ways to help which you will discover.

1. Learn Github and get a free opensource account
2. Learn to compile O, then start testing O in the development "master" thread. See the Dev manual.
3. Submit Github "Issues" or to Flyspray or tracker.
4. Help fix small parts of the code when a bug arises and submit a PR
5. Learn to compile plugins "in-line" and "standalone".
6. Help with bugs in plugins by submitting PR's.
7. Improve and update the O manual and Dev Manual as an editor.

https://opencpn.org/wiki/dokuwiki/do...veloper_manual

[RobTD]

Thanks for the welcome!

[Rasbats]

Sorry ... 'ocpn_plugin.h' again!

#ifdef MAKING_PLUGIN
extern   DECL_IMP wxEventType wxEVT_DOWNLOAD_EVENT;
#else
extern   DECL_EXP wxEventType wxEVT_DOWNLOAD_EVENT;
#endif

On the MacOS 'DECL_IMP' is not recognised. Used this:

#ifdef MAKING_PLUGIN
extern   DECL_EXP wxEventType wxEVT_DOWNLOAD_EVENT;
#endif

I have been unable to find where ''DECL_IMP' is defined. Could somebody point me to the source of this? It is not found in the OpenCPN master code.

Mike

[CarCode]

Originally Posted by Rasbats

I have been unable to find where ''DECL_IMP' is defined. Could somebody point me to the source of this? It is not found in the OpenCPN master code.
Mike

Line 39 in ocpn_plugin.h

#ifdef __WXMSW__
#ifdef MAKING_PLUGIN
#  define DECL_IMP     __declspec(dllimport)
#endif
#endif

Dirty and obfuscating programming style of Dave Register...

[Rasbats]

Yes ... but this is not for MacOS?

And further down 'ocpn_plugin.h' we find:

#ifdef MAKING_PLUGIN
extern   DECL_IMP wxEventType wxEVT_DOWNLOAD_EVENT;
#else
extern   DECL_EXP wxEventType wxEVT_DOWNLOAD_EVENT;
#endif

where there is no mention of __WXOSX__. Hence the error produced in Xcode.

Mike

[CarCode]

Why you defined "MAKING_PLUGIN" ?

[Rasbats]

Not me. It is in the OpenCPN source code 'ocpn_plugin.h'.

By including the definition in CMakeLists.txt it allows feedback from
"wxEVT_DOWNLOAD_EVENT"

long handle;
    OCPN_downloadFileBackground(url.BuildURI(), tmp_file, this, &handle);

    while (!m_bTransferComplete && m_bTransferSuccess)
    {
        wxYield();
        wxMilliSleep(30);
    }

    if (m_bTransferSuccess) {
        m_status->SetValue("Boats for this user are found");
    }
    else {
        m_status->SetValue("No user boats");
        return;
    }

Mike

[CarCode]

A backdoor for malware?
You should cancel it and destroy such things.

[rgleason]

Saw this recently


S-41X Marine Weather Overlays for future compatibility as overlays on chartplotters.

https://ocean.weather.gov/S-41X/index.php

[rgleason]

OpenCPN - Tidewise Repository- Commits -some may be useful

https://github.com/tidewise/gui-seab...commits/master

[Antipole]

I have a plugin with a couple of wxTextCntl windows in the dialog panel.

Under v5.0.1 you can Select all (on MacOS command-A) and it selects the whole window content.

With v5.1.605 this does not work - nothing happens.

This is the case with the same plugin build installed into both OPCN versions. The plugin is not involved in this process - it is an internal wxWindows function.

My hunch is that the command-A is not being sent through.

[Rasbats]

New subject:
Question: Does pressing the MOB button generate a JSON message or is the waypoint generated available in another JSON message?

Looking at automating the entry of the Datum for the SAR plugin.

Mike

[stevead]

New subject: Plugin Development

Originally Posted by Rasbats

Rick prompted me to learn more about the new plugin packaging system. Using Jon Gough's 'testplugin_pi' as a template the plugin can be installed in the latest OpenCPN beta by importing the tarball"

Where can one find information on the new plugin packaging system ?

[rgleason]

It needs updating as the system has moved on from here, but it should help.
https://opencpn.org/wiki/dokuwiki/do...r_build_deploy
and the other pages. Also Leamas has a wiki for the Plugin Manager too its in his fork of Opencpn..

I would suggest trying to use frontend2, the primary example is testplugin_pi by Jon Gough. I have a fork of that with some more guidance too.
https://github.com/jongough/testplugin_pi
https://github.com/rgleason/testplugin_pi


Currently, Jon is updating and improving testplugin again, and working on easier push of metadata to opencpn/plugins so you may see so recent activity from him.


In addition to "import plugin tarball" which is basicallly intended for guick developer testing and other handy needs, you can submit the metadata.xml files to the master branch of opencpn/plugins and make a PR to have the plugin available in the master catalog. This should be done after you are pretty sure it all works. Dave will review the PR and accept if it looks ok.