Beta Test / Technical

[stevead]

WTF.

Gripe 1,

Following error message during Appveyor build.

Chocolatey installed 3/3 packages.
See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
Start-FileDownload http://opencpn.navnux.org/build_deps/nsis-3.04-setup.exe
Start-FileDownloadInternal : Error downloading remote file: One or more errors occurred.
Inner Exception: Remote server returned 403: Forbidden
At C:\Program Files\AppVeyor\BuildAgent\Modules\build-worker-api\build-worker-api.psm1:242 char:2
+ Start-FileDownloadInternal -Url $Url -FileName $FileName -Timeout ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : NotSpecified: (:) [Start-FileDownloadInternal], Exception
+ FullyQualifiedErrorId : System.Exception,Appveyor.BuildAgent.Api.Utils.StartFileDownloadInternalCmdlet
nsis-3.04-setup.exe /S

Similar sounding failure from Circle CI MacOS build

wget -q http://opencpn.navnux.org/build_deps/wx312_opencpn50_macos109.tar.xz
+ tar xJf wx312_opencpn50_macos109.tar.xz -C /tmp
tar: Unrecognized archive format
tar: Error exit delayed from previous errors.

Who's responsible for opencpn.navnux.org ?

Gripe 2.

Following error message from CircleCI Mac OSX build

HEAD is now at 24f789860 Merge pull request #9336 from jonchang/refactor-git-extensions
Error: homebrew-core is a shallow clone. To `brew update` first run:
  git -C "/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core" fetch --unshallow
Failed during: /usr/local/bin/brew update --force
+ set -o pipefail
+ for pkg in cairo cmake libarchive libexif wget
+ brew list cairo
==> Downloading https://homebrew.bintray.com/bottles-portable-ruby/portable-ruby-2.6.3_2.yosemite.bottle.tar.gz
######################################################################## 100.0%
==> Pouring portable-ruby-2.6.3_2.yosemite.bottle.tar.gz
Error: No such keg: /usr/local/Cellar/cairo
+ brew install cairo
Error: homebrew-core is a shallow clone. To `brew update` first run:
  git -C "/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core" fetch --unshallow
Error: No available formula or cask with the name "cairo".
==> Searching taps on GitHub...
Error: No formulae found in taps.
+ brew upgrade cairo
Error: homebrew-core is a shallow clone. To `brew update` first run:
  git -C "/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core" fetch --unshallow
Error: No available formula or cask with the name "cairo".

Exited with code exit status 1

CircleCI received exit code 1

Found updated circleci-build-macos.sh scripts from another plugin developer's repo, which seemed to have addressed above problem.

Would be really nice if plugin developers were given a heads-up of necessary changes to the CI build scripts.

If you want plugin developers to support the plugin manager (which is a great benefit for end-users), at least make it easier for plugin developers.

Gripe 3.

NMEA 183 libraries.

Gripe 3(a) XTE.CPP

NMEA0183_BOOLEAN check = sentence.IsChecksumBad( 15 );

FFS. I guess this bug has been present since day 1 ??
And what about the FAA Mode Indicator ??

Gripe 3(b) When is a double not a double ?

Any of the NMEA libraries that have lat/long members (GLL, GGA, RMC etc,) simply and incorrecty, convert the lat/long string to a double.

$GPRMC,164547.00,A,3807.397,S,14424.121,E,6.2,90,240620,,,A*63

NMEA183::Rmc.Position.Longitude.Longitude gives 14424.121 which is clearly incorrect. We all know it should be 144 degrees 24.121 minutes which expressed as a double is 144.4020. I spent ages wondering why my code was interpreting weird positions.

It was only after looking at the NMEA 183 library code that I realised it was wrong. And I subsequently discovered buried deep in chart1.cpp that the OpenCPN code specifically parses this incorrect value to obtain the correct value.

Wouldn't it have been better to fix the f....g library instead of working around it and expecting every developer who uses the libraries to identify & fix the same f...g problem.

[Hakan]

Originally Posted by stevead

WTF.

And what about the FAA Mode Indicator ??

Check rmb.cpp and rmc.cpp and you'll find it's handled there.

Gripe 3(b) When is a double not a double ?

Any of the NMEA libraries that have lat/long members (GLL, GGA, RMC etc,) simply and incorrecty, convert the lat/long string to a double.

$GPRMC,164547.00,A,3807.397,S,14424.121,E,6.2,90,240620,,,A*63

NMEA183::Rmc.Position.Longitude.Longitude gives 14424.121 which is clearly incorrect. We all know it should be 144 degrees 24.121 minutes which expressed as a double is 144.4020. I spent ages wondering why my code was interpreting weird positions.

Extract from: NEMA protocol V2.8
"............
Where a numeric latitude or longitude is given, the two digits
immediately to the left of the decimal point are whole minutes, to the
right are decimals of minutes, and the remaining digits to the left of
the whole minutes are whole degrees.
Eg. 4533.35 is 45 degrees and 33.35 minutes. ".35" of a minute is
exactly 21 seconds.
Eg. 16708.033 is 167 degrees and 8.033 minutes. ".033" of a minute is
about 2 seconds.
--------"
So, you've to split the text position indicators into e.g. decimal degress before making it a double. See e.g. AIS_decoder.cpp ~955 for one method.

[rgleason]

Steve, I read an Issue note from Pavel that the free service for navnux was being discontinued and Pavel is transferring the files to somewhere on opencpn.org. I will try to find the notice for you.

Similar sounding failure from Circle CI MacOS build
Code:
wget -q http://opencpn.navnux.org/build_deps...acos109.tar.xz + tar xJf wx312_opencpn50_macos109.tar.xz -C /tmp tar: Unrecognized archive format tar: Error exit delayed from previous errors.
Who's responsible for opencpn.navnux.org ?

See https://github.com/OpenCPN/OpenCPN/i...ment-740229209


Here is where it is available I believe
https://github.com/OpenCPN/OpenCPN/i...ment-740247227


Pavel wrote:

It is currently available at https://download.opencpn.org/s/rwoCNGzx6G34tbC/download, so curl -o wx312B_opencpn50_macos109.tar.xz https://download.opencpn.org/s/rwoCNGzx6G34tbC/download should do.

This will affect all macos builds I believe Opencpn & Plugins. So they all need to be changed.

[rgleason]

Keep an eye on this Issue for necessary updates to the location for building with vital files.
https://github.com/OpenCPN/OpenCPN/i...ment-740649256


Perhaps someone will soon publish here the new paths for these vital files for building, when known.

[rgleason]

Xcode 11.3 +MACOSX_DEPLOYMENT_TARGET=10.9 should be OK? -Yes
Currently available at https://download.opencpn.org/s/rwoCNGzx6G34tbC/download, so curl -o wx312B_opencpn50_macos109.tar.xz https://download.opencpn.org/s/rwoCNGzx6G34tbC/download

Also fails in appveyor http://opencpn.navnux.org/build_deps...3.04-setup.exe, needs an update...

Also fails in appveyor link for wxWidgets-3.1.2.7z , need this link too.

Also 'nsis-3.04-setup.exe' is not recognized
What other vital building files are needed due to change from navnux to opencpn.org hosting website?

[rgleason]

Dave,

It might be a good idea to have under opencpn.org Downloads a "Vital Build Files" section with a link to each file? When the dust settles and it can be done.
In here somewhere?

https://opencpn.org/OpenCPN/info/downloads.html

[jongough]

I think putting the files in the Downloads section of the website seems like a good idea. I prefer easily readable URL's so that I know where I am getting stuff from and can test things easier.



If the files do move to the downloads section it would be useful to be able to 'list' them from the webpage as well as download them. This will help with debugging if anything happens to them.

[jongough]

Using the new location of the wx312B file the macos build has got further, however there is another file that was downloaded from navnux

http://opencpn.navnux.org/build_deps/Packages.dmg

Where can this file now be found?

[stevead]

Hakan,

I'm refering to the NMEA 183 libraries that are used by OpenCPN. Look in the libs folder of the OpenCPN repository.

I would assume that every other plugin developer would use he same libraries, just for convenience's sake.

While FAA Mode is handled by the rmc & rmb classes, it is not handled in the xte class.

What I'm saying is that a plugin developer would naively assume that the whenever they parse a rmc, gga or gll sentence using the same NMEA 183 libraries that are used by OpenCPN, that they would expect that the positions are correct. They aren't. If you look in the opencpn chart1.cpp source, you will notice that even opencpn has to reparse a lat/long,

[rgleason]

To add to the list of Vital Build Files

The macos plugin builds also need http://opencpn.navnux.org/build_deps/Packages.dmg which is not available. Is there a new location for that file?

https://download.opencpn.org/s/SneCR3z9XM3aRc6/download

[rgleason]

wget -q http://opencpn.navnux.org/build_deps...acos109.tar.xz

is now

curl -o wx312B_opencpn50_macos109.tar.xz https://download.opencpn.org/s/rwoCNGzx6G34tbC/download

[rgleason]

In place of nsis downloads from navnux, use something like

# - choco install nsis-3.04 -x86 - ps: Start-FileDownload https://download.opencpn.org/s/54HsBDLNzRZLL6i/download -FileName nsis-3.04-setup.exe - cmd: nsis-3.04-setup.exe /S

[rgleason]

See Alec's list for Vital Build Files that have moved.

Download links for build dependencies broken/updated. #2125


This list does not include nsis file download location.

[rgleason]

As Alec suggested:

CloudSmith OpenCPN Organization Repository folder "x-buildfiles" has some of the viital build files:
https://cloudsmith.io/~opencpn/repos...iles/packages/
https://cloudsmith.io/~opencpn/repos...iles/packages/

1. These files are Open Source and public.
2. CloudSmith OpenCPN Organization Plugin Team has access to these files and I believe is able to update/add files.
3. The x-buildfiles folder has an "x" so that it lands at the end and does not mess up the 3 folder arrangement of plugins.

Packages.dmg for macOS can be installed using brew, see: https://github.com/OpenCPN/OpenCPN/b...build-macos.sh


Reminder: I think this should also be noted in the Dev Manual.

[rgleason]

The files have been deleted as per bdbcat request.

Originally Posted by rgleason

As Alec suggested:

CloudSmith OpenCPN Organization Repository folder "x-buildfiles" has some of the viital build files:
https://cloudsmith.io/~opencpn/repos...iles/packages/
https://cloudsmith.io/~opencpn/repos...iles/packages/

1. These files are Open Source and public.
2. CloudSmith OpenCPN Organization Plugin Team has access to these files and I believe is able to update/add files.
3. The x-buildfiles folder has an "x" so that it lands at the end and does not mess up the 3 folder arrangement of plugins.

Packages.dmg for macOS can be installed using brew, see: https://github.com/OpenCPN/OpenCPN/b...build-macos.sh


Reminder: I think this should also be noted in the Dev Manual.