Beta Test / Technical

[bcn]

Even so - I would stay with actual ones.
Another setting/option?

[rgleason]

Trying to Debug with MSVC++ have copied uidata and am still getting an error. (is there anything else needed perhaps?) It compiles fine. See attached.

[oystercatcher]

I am unable to access the tracker/flyspray and would like to report a problem with
fedora 22 alpha and opencpn from git failing at make.

I tested fedora 21 and opencpn from git compiles.

I would appreciate some information on how to debug the make.


patrick

[nohal]

patrick...
Your problem is that the build fails on F22, right? You debug it by reading the error messages produced.
If you don't underdstand what they mean, you can post them here and we will have a look.

Pavel

[oystercatcher]

Originally Posted by nohal

patrick...
Your problem is that the build fails on F22, right? You debug it by reading the error messages produced.
If you don't underdstand what they mean, you can post them here and we will have a look.

Pavel

Thanks Pavel. I am posting the last messages from the make step. The cmake
appears to be correct but I have saved the messages from that step as well
I reported this error about a week ago but wasnt sure if it was only a problem
with fc22 so I went back to fc21 and opencpn compiles ok.



Linking CXX executable opencpn
/usr/bin/cmake -E cmake_link_script CMakeFiles/opencpn.dir/link.txt --verbose=1
/usr/lib64/ccache/c++ -pthread -O3 -DNDEBUG CMakeFiles/opencpn.dir/src/chart1.cpp.o CMakeFiles/opencpn.dir/src/bbox.cpp.o CMakeFiles/opencpn.dir/src/ocpn_pixel.cpp.o CMakeFiles/opencpn.dir/src/ocpndc.cpp.o CMakeFiles/opencpn.dir/src/chartdb.cpp.o CMakeFiles/opencpn.dir/src/chartdbs.cpp.o CMakeFiles/opencpn.dir/src/chartimg.cpp.o CMakeFiles/opencpn.dir/src/chcanv.cpp.o CMakeFiles/opencpn.dir/src/ocpCursor.cpp.o CMakeFiles/opencpn.dir/src/TCWin.cpp.o CMakeFiles/opencpn.dir/src/S57QueryDialog.cpp.o CMakeFiles/opencpn.dir/src/s57RegistrarMgr.cpp.o CMakeFiles/opencpn.dir/src/GoToPositionDialog.cpp.o CMakeFiles/opencpn.dir/src/CM93DSlide.cpp.o CMakeFiles/opencpn.dir/src/RolloverWin.cpp.o CMakeFiles/opencpn.dir/src/ChInfoWin.cpp.o CMakeFiles/opencpn.dir/src/AISTargetQueryDialog.cpp.o CMakeFiles/opencpn.dir/src/AIS_Bitstring.cpp.o CMakeFiles/opencpn.dir/src/AISTargetListDialog.cpp.o CMakeFiles/opencpn.dir/src/AISTargetAlertDialog.cpp.o CMakeFiles/opencpn.dir/src/AIS_Decoder.cpp.o CMakeFiles/opencpn.dir/src/AIS_Target_Data.cpp.o CMakeFiles/opencpn.dir/src/OCPNListCtrl.cpp.o CMakeFiles/opencpn.dir/src/Quilt.cpp.o CMakeFiles/opencpn.dir/src/Hyperlink.cpp.o CMakeFiles/opencpn.dir/src/NavObjectCollection.cpp.o CMakeFiles/opencpn.dir/src/RoutePoint.cpp.o CMakeFiles/opencpn.dir/src/Route.cpp.o CMakeFiles/opencpn.dir/src/SelectItem.cpp.o CMakeFiles/opencpn.dir/src/Select.cpp.o CMakeFiles/opencpn.dir/src/FontMgr.cpp.o CMakeFiles/opencpn.dir/src/FontDesc.cpp.o CMakeFiles/opencpn.dir/src/OCPNSoundData.cpp.o CMakeFiles/opencpn.dir/src/OCPN_Sound.cpp.o CMakeFiles/opencpn.dir/src/NMEALogWindow.cpp.o CMakeFiles/opencpn.dir/src/TTYWindow.cpp.o CMakeFiles/opencpn.dir/src/TTYScroll.cpp.o CMakeFiles/opencpn.dir/src/SendToGpsDlg.cpp.o CMakeFiles/opencpn.dir/src/Layer.cpp.o CMakeFiles/opencpn.dir/src/concanv.cpp.o CMakeFiles/opencpn.dir/src/cutil.cpp.o CMakeFiles/opencpn.dir/src/georef.cpp.o CMakeFiles/opencpn.dir/src/navutil.cpp.o CMakeFiles/opencpn.dir/src/routeman.cpp.o CMakeFiles/opencpn.dir/src/routemanagerdialog.cpp.o CMakeFiles/opencpn.dir/src/routeprop.cpp.o CMakeFiles/opencpn.dir/src/routeprintout.cpp.o CMakeFiles/opencpn.dir/src/PositionParser.cpp.o CMakeFiles/opencpn.dir/src/printtable.cpp.o CMakeFiles/opencpn.dir/src/statwin.cpp.o CMakeFiles/opencpn.dir/src/tcmgr.cpp.o CMakeFiles/opencpn.dir/src/Station_Data.cpp.o CMakeFiles/opencpn.dir/src/IDX_entry.cpp.o CMakeFiles/opencpn.dir/src/TCDataFactory.cpp.o CMakeFiles/opencpn.dir/src/TCDS_Ascii_Harmonic.cpp.o CMakeFiles/opencpn.dir/src/TCDS_Binary_Harmonic.cpp.o CMakeFiles/opencpn.dir/src/TCDataSource.cpp.o CMakeFiles/opencpn.dir/src/thumbwin.cpp.o CMakeFiles/opencpn.dir/src/options.cpp.o CMakeFiles/opencpn.dir/src/gshhs.cpp.o CMakeFiles/opencpn.dir/src/kml.cpp.o CMakeFiles/opencpn.dir/src/undo.cpp.o CMakeFiles/opencpn.dir/src/about.cpp.o CMakeFiles/opencpn.dir/src/ais.cpp.o CMakeFiles/opencpn.dir/src/pluginmanager.cpp.o CMakeFiles/opencpn.dir/src/gpxdocument.cpp.o CMakeFiles/opencpn.dir/src/wxJSON/jsonwriter.cpp.o CMakeFiles/opencpn.dir/src/wxJSON/jsonreader.cpp.o CMakeFiles/opencpn.dir/src/wxJSON/jsonval.cpp.o CMakeFiles/opencpn.dir/src/styles.cpp.o CMakeFiles/opencpn.dir/src/toolbar.cpp.o CMakeFiles/opencpn.dir/src/compasswin.cpp.o CMakeFiles/opencpn.dir/src/geodesic.cpp.o CMakeFiles/opencpn.dir/src/datastream.cpp.o CMakeFiles/opencpn.dir/src/OCPN_DataStreamEvent.cpp.o CMakeFiles/opencpn.dir/src/ConnectionParams.cpp.o CMakeFiles/opencpn.dir/src/OCP_DataStreamInput_Thread.cpp.o CMakeFiles/opencpn.dir/src/multiplexer.cpp.o CMakeFiles/opencpn.dir/src/pugixml.cpp.o CMakeFiles/opencpn.dir/src/OCPNRegion.cpp.o CMakeFiles/opencpn.dir/src/TrackPropDlg.cpp.o CMakeFiles/opencpn.dir/src/LinkPropDlg.cpp.o CMakeFiles/opencpn.dir/src/ssl/sha1.c.o CMakeFiles/opencpn.dir/src/viewport.cpp.o CMakeFiles/opencpn.dir/src/canvasMenu.cpp.o CMakeFiles/opencpn.dir/src/OCPNPlatform.cpp.o CMakeFiles/opencpn.dir/src/crashprint.cpp.o CMakeFiles/opencpn.dir/src/glChartCanvas.cpp.o CMakeFiles/opencpn.dir/src/glTextureDescriptor.cpp.o CMakeFiles/opencpn.dir/src/glTexCache.cpp.o CMakeFiles/opencpn.dir/src/TexFont.cpp.o -o opencpn -L/usr/local/src/OpenCPN/build -rdynamic -pthread -Wl,-z,relro -lwx_baseu-2.8 -lwx_gtk2u_core-2.8 -lwx_baseu_net-2.8 -lwx_baseu_xml-2.8 -lwx_gtk2u_html-2.8 -lwx_gtk2u_adv-2.8 -lwx_gtk2u_aui-2.8 -lwx_gtk2u_gl-2.8 libNMEA0183.a -lglib-2.0 -lgobject-2.0 -latk-1.0 -lgio-2.0 -lgthread-2.0 -lgmodule-2.0 -lgdk_pixbuf-2.0 -lcairo -lpango-1.0 -lpangocairo-1.0 -lpangoft2-1.0 -lpangoxft-1.0 -lgdk-x11-2.0 -lgtk-x11-2.0 -lportaudio libS57ENC.a libGARMINHOST.a libSYMBOLS.a libTEXCMP.a -lGLU -lGL -lbz2 -lz -ltinyxml -ldl -lgobject-2.0
libS57ENC.a(tri.c.o): In function `int_is_left_of':
/usr/local/src/OpenCPN/src/tri.c:3094: undefined reference to `int_greater_than'
libS57ENC.a(tri.c.o): In function `int_inside_polygon':
/usr/local/src/OpenCPN/src/tri.c:3159: undefined reference to `int_greater_than'
/usr/local/src/OpenCPN/src/tri.c:3161: undefined reference to `int_equal_to'
/usr/local/src/OpenCPN/src/tri.c:3164: undefined reference to `int_equal_to'
/usr/local/src/OpenCPN/src/tri.c:3167: undefined reference to `int_equal_to'
/usr/local/src/OpenCPN/src/tri.c:3170: undefined reference to `int_equal_to'
libS57ENC.a(tri.c.o): In function `int_find_new_roots':
/usr/local/src/OpenCPN/src/tri.c:3546: undefined reference to `int_locate_endpoint'
/usr/local/src/OpenCPN/src/tri.c:3549: undefined reference to `int_locate_endpoint'
libS57ENC.a(tri.c.o): In function `int_merge_trapezoids':
/usr/local/src/OpenCPN/src/tri.c:3570: undefined reference to `int_greater_than_equal_to'
libS57ENC.a(tri.c.o): In function `int_add_segment':
/usr/local/src/OpenCPN/src/tri.c:3658: undefined reference to `int_greater_than'
/usr/local/src/OpenCPN/src/tri.c:3675: undefined reference to `int_locate_endpoint'
/usr/local/src/OpenCPN/src/tri.c:3725: undefined reference to `int_locate_endpoint'
/usr/local/src/OpenCPN/src/tri.c:3735: undefined reference to `int_locate_endpoint'
/usr/local/src/OpenCPN/src/tri.c:3788: undefined reference to `int_locate_endpoint'
/usr/local/src/OpenCPN/src/tri.c:3831: undefined reference to `int_equal_to'
/usr/local/src/OpenCPN/src/tri.c:3806: undefined reference to `int_greater_than_equal_to'
collect2: error: ld returned 1 exit status
CMakeFiles/opencpn.dir/build.make:2363: recipe for target 'opencpn' failed
make[2]: *** [opencpn] Error 1
make[2]: Leaving directory '/usr/local/src/OpenCPN/build'
CMakeFiles/Makefile2:305: recipe for target 'CMakeFiles/opencpn.dir/all' failed
make[1]: *** [CMakeFiles/opencpn.dir/all] Error 2
make[1]: Leaving directory '/usr/local/src/OpenCPN/build'
Makefile:139: recipe for target 'all' failed
make: *** [all] Error 2
[pstan@logarithm-f22-ci-org build]$

[nohal]

It certainly is FC22, or better say GCC5 related. I suppose the following patch should fix it.

diff --git a/include/triangulate.h b/include/triangulate.h
index 7a12790..74239b2 100644
--- a/include/triangulate.h
+++ b/include/triangulate.h
@@ -245,4 +245,13 @@ extern int read_segments(char *, int *);
 extern int math_logstar_n(int);
 extern int math_N(int, int);
 
+extern inline int int_greater_than(ipoint_t *v0, ipoint_t *v1);
+extern inline int int_equal_to(ipoint_t *v0, ipoint_t *v1);
+extern inline int int_greater_than_equal_to(ipoint_t *v0, ipoint_t *v1);
+extern inline int int_less_than(ipoint_t *v0, ipoint_t *v1);
+#ifndef __clang__
+extern inline int int_locate_endpoint_a(ipoint_t *v, ipoint_t *vo, int r);
+#endif
+extern inline int int_locate_endpoint(ipoint_t *v, ipoint_t *vo, int r);
+
 #endif /* triangulate_h */

Pavel

[oystercatcher]

thank you pavel,

make completes with opencpn.
I especially want to thank you for this fix as fc22 is still alpha software.

Originally Posted by nohal

It certainly is FC22, or better say GCC5 related. I suppose the following patch should fix it.

diff --git a/include/triangulate.h b/include/triangulate.h
index 7a12790..74239b2 100644
--- a/include/triangulate.h
+++ b/include/triangulate.h
@@ -245,4 +245,13 @@ extern int read_segments(char *, int *);
 extern int math_logstar_n(int);
 extern int math_N(int, int);
 
+extern inline int int_greater_than(ipoint_t *v0, ipoint_t *v1);
+extern inline int int_equal_to(ipoint_t *v0, ipoint_t *v1);
+extern inline int int_greater_than_equal_to(ipoint_t *v0, ipoint_t *v1);
+extern inline int int_less_than(ipoint_t *v0, ipoint_t *v1);
+#ifndef __clang__
+extern inline int int_locate_endpoint_a(ipoint_t *v, ipoint_t *vo, int r);
+#endif
+extern inline int int_locate_endpoint(ipoint_t *v, ipoint_t *vo, int r);
+
 #endif /* triangulate_h */

Pavel

[rgleason]

The most recent master is not compiling
3>------ Build started: Project: opencpn, Configuration: Debug Win32 ------
3>LINK : fatal error LNK1104: cannot open file 'Debug\S57ENC.lib'
========== Build: 1 succeeded, 2 failed, 5 up-to-date, 0 skipped ==========
Under Windows.

I think since Sean's additions. I am going to try going back a step.

[rgleason]

Actually, for some reason, that LIB file was missing from build/debug directory, when it had been working just hours ago. Sorry Sean..its not related.

[rgleason]

Well I thought I had fixed the S57 chart problem, but it still exists. This is getting to be too much to do while on the move. Signing off.

[rgleason]

Just to check it, I git checkout v4.0 and compiled it without s57 problems. Something is busted in master v4.1 related to s57 when compile for win.

Sent from my SCH-I545 using Cruisers Sailing Forum mobile app

[CarCode]

Originally Posted by rgleason

Just to check it, I git checkout v4.0 and compiled it without s57 problems. Something is busted in master v4.1 related to s57 when compile for win.

Sent from my SCH-I545 using Cruisers Sailing Forum mobile app

Rick,
comment out the latest diffs in triangulate.h (see post #1356 above) and it should work.

Gerhard

[rgleason]

Thanks Gerhard. Will try that.

Sent from my SCH-I545 using Cruisers Sailing Forum mobile app

[Hakan]

In Win build by MVC++ 2010:
The last commit in Github solved the build error for trianglulate.h, thanks.
But for info there are still some minor errors in:
mygeom.cpp
..\src\mygeom.cpp(913): error C3861: 'fmax': identifier not found
..\src\mygeom.cpp(914): error C3861: 'fmin': identifier not found

I temporarily solved it by:

diff --git a/src/mygeom.cpp b/src/mygeom.cpp
index 1f36a96..6ceb8d5 100644
--- a/src/mygeom.cpp
+++ b/src/mygeom.cpp
@@ -65,6 +65,7 @@

 #ifdef __WXMSW__
 #include <windows.h>
+#include "dychart.h"
 #endif

It seems to be Win dependent but please have a look.
Håkan

[rgleason]

Hakan, ageeed.

Sent from my SCH-I545 using Cruisers Sailing Forum mobile app