Beta Test / Technical

[rgleason]

Opncpn v4.1.602 on SurfacePro3 win8.1 settings user interface check enable tablet scaled... does not increase size of toolbar icons.

Sent from my SCH-I545 using Cruisers Sailing Forum mobile app

[.Paul.]

This morning I built OpenCPN 4.1.705 after "git fetch --all" to include

Merge branch 'did-g-trivial_speedup'
latest commit dde82725fa
David Register authored 11 hours ago

from about 23:00 EDT (03:00 UTC).

VS2013 command prompt was used for the build, and I installed the package in Win8.1.

This version hangs when attempting to close the Options-Connections dialog using the "OK" button. It also hangs if the "Apply" button is used. "Cancel" closes the dialog as expected. When it hangs, the window name changes to "Options (Not Responding)", and the CPU usage reported by Task Manager for OpenCPN 4.1.705 goes to zero.


Paul

[bdbcat]

Paul....

Please pull the latest github master. This bug fixed this morning.

Thanks
Dave

[.Paul.]

Dave,

That fixed it.

Thanks,
Paul

[rgleason]

Does enlarge toolbar icons in opencpn 4.0, nicely.

Sent from my SCH-I545 using Cruisers Sailing Forum mobile app

[rgleason]

Pavel,
I think there is a small problem in Cmake files for plugins. Both Ocpn_draw and Watchdog_pi seem to create a second level Opencpn folder under the parallel install directory Opencpn4.1.718, and then I find the plugins under that and have to copy them back out to the proper "Opencpn4.1.718/plugins" directory. Has been happening for quite awhile. Thought it was something the plugin author did at first.


http://www.cruisersforum.com/forums/...ml#post1879278

http://www.cruisersforum.com/forums/...ml#post1879821

http://www.cruisersforum.com/forums/...ml#post1879697

Can you fix it for us? Thanks.

[nohal]

Rick...
This "problem" is there since the very beginning. And as it is a very minor annoyance not affecting the standard installations at all, it is very low on the list. If you want it fixed faster, study a bit about NSIS and post a patch (I know exactly nothing about it as well, so you may take it as a challenge in who will learn it faster)

Pavel

[rgleason]

Pavel, not so sure it was the beginning, I thought it worked fine for a long time and something changed. Do you think the problem is in the NSIS code for the plugins exe? - This would give me a place to start.

[nohal]

Rick...
Yes, it was like this since the very moment the plugin packaging was implemented.
The place to start is https://github.com/nohal/chartdldr_p...kage.cmake#L25 and https://github.com/nohal/chartdldr_p...IS.template.in
I suppose that what you need to do is modify the later to make the installer forget about the former once the user selects a "non-standard" installation path.

Pavel

[rgleason]

Thanks Pavel, I will try. Hope not to flunk. There is a little weirdness too, Win8.1 OS do not have a problem with this, watchdog and ocpn_draw install ok.

[nohal]

Rick...
Every plugin installs OK on every Windows version, you just have to remove the final part of the path when installing to a non-standard location. I don't have W8.1 and never did, but it seems kind of impossible that the installer behaves differently on it than on other Win versions. And don't worry, even if it did, on W10 the installer behaves again the same as on all the other versions I have ever seen.

Pavel

[bcn]

The installer behaves the same under W8.1 as Pavel was assuming.
And yes, this glitch does exist for several plug-ins.
Once you know what you have to do it's obvious, but for a beginner with a parallel install it can be a bit bewildering...

[rgleason]

Yes, BCN, thanks. That was my point. I am going to try to fix it, before some smarter person fixes it before me.

[rgleason]

https://github.com/nohal/chartdldr_p...IS.template.in

!define INST_DIR "@CPACK_TEMPORARY_DIRECTORY@"


https://github.com/nohal/chartdldr_p...kage.cmake#L24

IF(WIN32)
# to protect against confusable windows users, let us _not_ generate zip packages
# SET(CPACK_GENERATOR "NSIS;ZIP")

# override install directory to put package files in the opencpn directory
SET(CPACK_PACKAGE_INSTALL_DIRECTORY "OpenCPN")


--Maybe that is quite literally what it does. Always install into an OpenCPN directory. I need to try not having "OpenCPN" in there and see what happens.

Would I just have double quotes with nothing between? ie: ""

[seandepagnier]

Originally Posted by bcn

The installer behaves the same under W8.1 as Pavel was assuming.
And yes, this glitch does exist for several plug-ins.
Once you know what you have to do it's obvious, but for a beginner with a parallel install it can be a bit bewildering...

I noticed this as well. It's specific to the plugins using nsis installer.

Maybe instead of just having a path with browse, it could enumerate radio buttons for each detected opencpn installation, as well as an option for custom path (if it didn't detect)