Celestial Navigation Plugin Redux

[P_Dub]

Originally Posted by stelian

Ok, it turns out that I had compiled the plugin against wxWidgets-3.1 (because this is what is recommended by transmitterdan's buildtools), whereas official OpenCPN is compiled against wxWidgets-3.0.

I've recompiled the plugin using the good version of wxWidgets and this time the celestial plugin installs ok on top of an "official" OpenCPN 4.8.0.

Get it here: http://popies.net/tmp/celestial_navi...1sp2-win32.exe

Stelian.

Will take a look later this evening. In the mean time thanks for the kind help.
Best Regards

[HUR450502]

Dear Stelian .....

you don't give up, don't you???

So you must be a professional "debugger" ... in my "early life" at my employer I was a PSR too and know the days (and nights) when the problem had you in its grip and not you the problem ....

So, again, great stuff, and I only can express my appreciation for all the efforts you (and all the others) put into this.

Now - however - I installed the mentioned "SP2" installation package. It installs without problems, starts, everything looks good - until you want to enter a second sighting.......

So, we are at the same pont, where we startet. Probably some problem with the new environment (widgets etc.) and not with the coding?

Honestly, I don't know where to go from here and I sure don't want to frustrate you. On the other hand, this is a permanent - reproducable problem and therefore I think, that we should have a way, to get it solved. ....

Anyway, thank you very much for all your efforts. ....

Best regards - and, before starting again on this problem, have a good sleep night ....

Uwe

[stelian]

Originally Posted by HUR450502

Dear Stelian .....

you don't give up, don't you???

So you must be a professional "debugger" ... in my "early life" at my employer I was a PSR too and know the days (and nights) when the problem had you in its grip and not you the problem ....

So, again, great stuff, and I only can express my appreciation for all the efforts you (and all the others) put into this.

Now - however - I installed the mentioned "SP2" installation package. It installs without problems, starts, everything looks good - until you want to enter a second sighting.......

So, we are at the same pont, where we startet. Probably some problem with the new environment (widgets etc.) and not with the coding?

Honestly, I don't know where to go from here and I sure don't want to frustrate you. On the other hand, this is a permanent - reproducable problem and therefore I think, that we should have a way, to get it solved. ....

Anyway, thank you very much for all your efforts. ....

Best regards - and, before starting again on this problem, have a good sleep night ....

Uwe

Yeah, I don't like giving up...

However, I don't have a problem with multiple sights. I can enter several (tried 4, 5, etc, tried removing some then adding again), it works OK, detects fixes when circles intersect, etc...

What is exactly your problem ?

Stelian.

[HUR450502]

Hi Stelian,

I just have the same problem now as I had from the beginnign, I can only enter one sight. when entering the second sight OpenCPN just crashes.

With the SP1 version of OpenCPN and the SP1 version of the plugin everything worked (I used the same sightings for both tests).

So, what I did, was, I re-installed the "original" version of OpenCPN 4.8.0 then installed the "SP2" plugin. Interestingly when opening the plugin it found the previously enteres sightings and calculated them - however incorrectly. I then deleted the sightings and entered them again. With the first sighting I got the correct line, but after entering the second sighting, OpenCPN crashed - as with the "official" Plugin (version2.0).

OK??

Best regards (and you see, I am testing late hours too .... :-) )

Uwe

[stelian]

Originally Posted by HUR450502

Hi Stelian,

I just have the same problem now as I had from the beginnign, I can only enter one sight. when entering the second sight OpenCPN just crashes.

With the SP1 version of OpenCPN and the SP1 version of the plugin everything worked (I used the same sightings for both tests).

So, what I did, was, I re-installed the "original" version of OpenCPN 4.8.0 then installed the "SP2" plugin. Interestingly when opening the plugin it found the previously enteres sightings and calculated them - however incorrectly. I then deleted the sightings and entered them again. With the first sighting I got the correct line, but after entering the second sighting, OpenCPN crashed - as with the "official" Plugin (version2.0).

OK??

Best regards (and you see, I am testing late hours too .... :-) )

Uwe

Ok, so probably we're hitting a wxWidgets bug here, which was corrected in 3.1 (that's why SP1 version works)

Now, what is interesting is that I cannot reproduce. What is exactly the data you enter in your sightings ? What is the language of your OpenCPN install ?

Stelian.

[P_Dub]

After one sight it bugs. At least you are on the good road, you are coming to fix it properly. If not you it will be the boss.
For now we can see the plugins works.
Thanks.

[HUR450502]

Originally Posted by stelian

Ok, so probably we're hitting a wxWidgets bug here, which was corrected in 3.1 (that's why SP1 version works)

Now, what is interesting is that I cannot reproduce. What is exactly the data you enter in your sightings ? What is the language of your OpenCPN install ?

Stelian.

Hi Stelian,

I am running Windows 10 - 1703 Build 15063.608 64 Bit, language German (so is OpenCPN as well)

The data I entered were (Oct.01. 2017, time 14:42:12 - same for all sightings - only elevation data):

Antares 23° 33.7'
Vega 52° 03.6'
Alioth 59° 45.8'

As I said, I could enter Antares correctly, the line is drawn, then I enter Vega and as soon as I hit the "OK" button, OpenCPN crashes.

Running the same on my Apple Mac/OS everything runs fine (and the calculation faster).

Does this help??

Hope you didn't have nightmares and slept well ....

Best regards, Uwe

[kubek]

Hi,

I would like to say that this is a great plugin and I am very interested in helping to solve the issue.

Same as others, when I try to enter second fix data, OpenCPN crashes.

Data entered:
Sun LL, 2.07.2017 15:36:20 UT, 58° 03.2', index error -1.5', Height of eye 2.0m
Sun LL, 2.07.2017 18:44:55 UT, 16° 45.0', index error -1.5', Height of eye 2.0m

I used official OpenCPN 4.8.0 and Celestial Navigation 2.0 plugin both downloaded from www.opencpn.org.

Windows 10 - 10.0.14393 Build 14393, LANG=English/US

08:43:01: 2017-10-02
08:43:01: ------- Starting OpenCPN -------
08:43:01: Version 4.8.0 Build 2017-08-11
08:43:01: wxWidgets version: wxWidgets 3.0.2 Microsoft Windows NT 64 bit wxMSW
08:43:01: MemoryStatus: mem_total: 32425 mb, mem_initial: 13 mb
...
8:43:07 AM: PlugInManager searching for PlugIns in location C:\Program Files (x86)\OpenCPN\plugins
8:43:07 AM: PlugInManager: Loading PlugIn: C:\Program Files (x86)\OpenCPN\plugins\celestial_navigation_pi.dll
8:43:07 AM: C:\Program Files (x86)\OpenCPN\plugins\celestial_navigation_pi.dll
API Version detected: 108
PlugIn Version detected: 200

I have attached screenshoots,
It maybe help to find out the root cause.

Kubek

[stelian]

Originally Posted by HUR450502

Does this help??

Yes, it really does !

It turns out that the crash is dependent on the data you enter !

I can now reproduce the bug with your data (and found out other sighting data which crashes OpenCPN too).

Let's see if I can find anything...

[HUR450502]

Hi Stelian,

I tried two times the sun at different times - of course - yes, and it works.

Am I possibly using too "exotic" stars?? Almanac problem(s)???

I think this is getting really interesting now.... :-)

Best regards,

Uwe

[rgleason]

Stelian, your skills and efforts have resurrected the celestial_navigation plugin. Thank you.
Is there a error message line we can insert somewhere which notifies that the file cannot be read because it is in the wrong format? To help next time this happens?

Thank you.

[stelian]

Hi everybody,

Someone wants to test : http://popies.net/tmp/celestial_navi...2sp3-win32.exe ?



Code pushed to http://github.com/stelian42/celestial_navigation_pi

[P_Dub]

Originally Posted by stelian

Hi everybody,

Someone wants to test : http://popies.net/tmp/celestial_navi...2sp3-win32.exe ?



Code pushed to http://github.com/stelian42/celestial_navigation_pi

Will do in 1 hour.
Thanks.

[HUR450502]

Originally Posted by stelian

Hi everybody,

Someone wants to test : http://popies.net/tmp/celestial_navi...2sp3-win32.exe ?



Code pushed to http://github.com/stelian42/celestial_navigation_pi

..... Dear Stelian .....

what should I say.... It works like a dream!!!! Absolutely great!!! Thanks a lot. Please let Sean into the secrets of the problem, I think he will appreciate it.

You will be awarded "professional BUGFIXER"!!!

I am sure, Rick is seeing to that.

Thank you again for your great help, making another valuable plugin from Sean useable again....

Thanks to all you team of OpenCPN and the Plugins for the great product as well.

All the best,

Uwe

[P_Dub]

Great, it works fine. What was the position found with your 3 stars?
2 programs gave me different answers.
OpenCpn:- 37*59.8`N 030* 18.9`E
Is this correct?
If so, you have done it.
Bye