Colors and Segments in Tracks

[PjotrC]

As per description in the Feature Requests thread, attached is the source patch #6.

To keep it small, I did not do immediate redrawing of just closed track, so it will stay red until next screen refresh.

Piotr

[PjotrC]

For those, who are willing to try this (& other source patches from my little factory) I include the summary of previous patches. They need to be applied in sequence (#5 is missing and not needed - will be never published).

opencpn_patch_bob - Forums - Post 401932">AIS-IRJDSUNE9932123321222xxeww-&-IRJDSUNE9932123321222xxeww-Bells

patch2_pv - Forums - Post 403951">AIS-IRJDSUNE9932123321222xxeww-Pleasure-IRJDSUNE9932123321222xxeww-Vessel

patch2a_bel - bells bug fix
patch3_trk - track properties dialog (as above)

patch3a_trk - track properties bug fix

patch4_awr - anchor watch
patch4a_snd - anchor alarm (sound), as above

patch6_col_seg - colors&segments in tracks

If necessary, I will prepare the cumulative patch, but the smaller patches are easier to look at and evaluate. At least two people reported success in applying them in Vista environment, so I think it is a better arrangement. Also, these patches will become irrelevant with the next release of OCPN...

[idpnd]

I will try.. Shouldn't this go into the CVS or into the GIT server as a branch?

[idpnd]

Got some errors on that sadly:

user@mariner:~/opencpn$ sudo make clean
test -z "opencpn" || rm -f opencpn
rm -f *.o
user@mariner:~/opencpn$ sudo make > make.txt
In file included from src/chart1.cpp:288:
././include/grib.h:83: warning: ‘typedef’ was ignored in this declaration
src/chart1.cpp: In member function ‘virtual int MyApp::OnExit()’:
src/chart1.cpp:1682: warning: cannot pass objects of non-POD type ‘class wxString’ through ‘...’; call will abort at runtime
src/chart1.cpp:1682: warning: cannot pass objects of non-POD type ‘class wxString’ through ‘...’; call will abort at runtime
src/chart1.cpp:1686: warning: cannot pass objects of non-POD type ‘class wxString’ through ‘...’; call will abort at runtime
src/chart1.cpp:1686: warning: cannot pass objects of non-POD type ‘class wxString’ through ‘...’; call will abort at runtime
src/chart1.cpp: In member function ‘void MyFrame::OnFrameTimer1(wxTimerEvent&)’:
src/chart1.cpp:3726: warning: cannot pass objects of non-POD type ‘class wxString’ through ‘...’; call will abort at runtime
src/chart1.cpp:3726: warning: cannot pass objects of non-POD type ‘class wxString’ through ‘...’; call will abort at runtime
src/chart1.cpp:3730: warning: cannot pass objects of non-POD type ‘class wxString’ through ‘...’; call will abort at runtime
src/chart1.cpp:3730: warning: cannot pass objects of non-POD type ‘class wxString’ through ‘...’; call will abort at runtime
src/chart1.cpp: In function ‘double AnchorDistFix(double, double, double)’:
src/chart1.cpp:6151: warning: suggest explicit braces to avoid ambiguous ‘else’
src/chart1.cpp:6155: warning: suggest explicit braces to avoid ambiguous ‘else’
src/chart1.cpp:6159: warning: control reaches end of non-void function
src/chart1.cpp: At global scope:
src/chart1.cpp:657: warning: ‘bells_sound_file_name’ defined but not used
In file included from src/chcanv.cpp:284:
././include/grib.h:83: warning: ‘typedef’ was ignored in this declaration
src/chcanv.cpp:2524: error: expected declaration before ‘}’ token
src/chcanv.cpp:406: warning: ‘mouse_leftisdown’ defined but not used
make: *** [chcanv.o] Error 1

[PjotrC]

I see you are at patch #4a

Did the previous sets compile OK? On Vista I only had the warning about AnchorDistFix control reaching end of non-void fn, which is true, but irrelevant, and no errors.

I have no Linux machine on hand to try...

Piotr

[idpnd]

Hehe!

They need to be applied in sequence

I applied them in sequence (all patches) and then compiled.. This is the first set I am compiling as I have been on holiday without pc

The error is definitely in one of the chcanv.o patches isnt it.. Perhaps I didn't apply them right?

Edit: Perhaps I didn't apply the chcanv.h patch from patch_bob, I had to put them in manually as I didn't manage to execute the .txt file.

[PjotrC]

Perhaps the attached cumulative patch script will help to prevent omissions.

Please note that it also contains reference to two patches to file georef.c, provided in a post by HamishB about calculating Mercator distances.

[idpnd]

Thanks for your patience Pjotr, unfortunately I still get the same error having done everything from scratch - must be a linux issue?

[PjotrC]

I assume you are patching against the base 1.3.6 release as provided in sourceforge file opencpn-1.3.6.tar.bz2 ?
Besides this, I am aware of the 2 patches to georef.c and a patch to nmea.h, which I do not use.

[idpnd]

I am patching the current CVS download, I have also pulled in the hamish patch set but couldn't get it to work. I don't think that would have any impact on this error I'm getting?

[PjotrC]

This does not explain the current problem you are experiencing, but I have indeed omitted one simple file from the patch #6. It is attached here. Of course, it should be added to the cumulative patch script as well.

P.