Custom Features

[lurno]

I have made some modifications to OCPN to satisfy my personal prefs:
Command line switch to able me to start two instances of OCPN with different config files. This enables me to have one window displaying an overview, next to the main window. Window size, location and other features is saved in the two config files. In addition I have made a switch to turn off the tool-bar as that is not needed in both windows.
Also I have made a mod to toggle course up via CTRL-C, and a mod CTRL-D to toggle the display modes listed in toolbox Rastercharts.
My mods are based upon beta code downloaded yesterday.
If any of this is of interest and not invented earlier, I can publish.
GIT is not my strong side though, so I would need some instructions on how to make the code available.

RGDS
Lasse

[nohal]

Lasse...
The latest code can already be run in portable mode with -p command line switch (but no turning off of the toolbar etc.). I would also personally probably hesitated a lot before using shortcuts as notorious to do something as Ctrl-C.

If you cloned the repository and then just changed the code without doing anything else

git diff > mypatch.diff

Will produce the patch with all the changes to the codebase (except added files, if any). More in Git Community Book - Chapter 3 will make you a fluent git user in about 10 minutes.

It would actually be much more convenient if you could submit more smaller patches implementing certain features in flyspray as feature requests than one containing everything, called "allmymods.diff".

Thanks

Pavel

[lurno]

nohal...
The reason I am in favour of the keyboard is the rocking of the boat, 40' motorized rocks a lot more than sail. hence use of the mouse i difficult.
I don't fully understand the use of the -p switch. I must be root here to run it.
Lasse

[nohal]

Lasse...
the -p switch runs opencpn in portable mode - the config etc. is loaded from the local directory and not from the default location (on Linux user, on Windows system wide). Could you be more specific about the reasons why you have to be root to use it? Perhaps you tried to run it in a location where your current user couldn't write?

I support the idea of the keyboard shortcuts of course, I just said I myself try not to use the combinations totally notorious for having some function for something else when I write the code. Obviously just a question of personal preference.

Pavel

[lurno]

nohal...
Here is what I get when starting OCPN in terminal with -p switch.
Also with this switch on, it does not find the maps.


17:17:00 CET: 2012-02-21
17:17:00 CET: -------Starting opencpn-------
17:17:00 CET: Version 2.6.1310 Build 2012-01-10
17:17:00 CET: MemoryStatus: mem_total: 3961 mb, mem_initial: 257 mb
17:17:00 CET: SData_Locn is /usr/local/bin/
17:17:00 CET: Using existing Config_File: /usr/local/bin/opencpn.conf
17:17:00 CET: Setting Viewpoint Lat/Lon 33.358, -79.282
17:17:00 CET: Setting Ownship Lat/Lon 33.358, -79.282
17:17:00 CET: Error: can't create file '/usr/local/bin/navobj.xml.1' (error 13: Permission denied)
17:17:00 CET: System default Language: en_US
17:17:00 CET: Opencpn language set to: en_US
17:17:00 CET: S52PLIB: Cannot open S52 rules file /usr/local/bin/s57data/S52RAZDS.RLE
17:17:00 CET: Looking for s57data in /home/lasse/.opencpn/s57data
17:17:00 CET: S52PLIB: Cannot open S52 rules file /home/lasse/.opencpn/s57data/S52RAZDS.RLE
17:17:00 CET: Looking for s57data in /usr/local/bin/s57data
17:17:00 CET: S52PLIB: Cannot open S52 rules file /usr/local/bin/s57data/S52RAZDS.RLE
17:17:00 CET: S52PLIB Initialization failed, disabling S57 charts.
17:17:00 CET: Using Tide/Current data from: /usr/local/bin/tcdata/
17:17:00 CET: Setting Viewpoint Lat/Lon 33.358, -79.282
17:17:00 CET: Setting Ownship Lat/Lon 33.358, -79.282
17:17:01 CET: NMEA Data Source is....NONE
17:17:01 CET: AIS Data Source is....NONE
17:17:01 CET: Unable to open WVSChart datafile: /usr/local/bin/wvsdata/wvs43.dat
17:17:01 CET: NMEA AutoPilot Port is....NONE
17:17:01 CET: PlugInManager searching for PlugIns in location /usr/local/bin/plugins
17:17:01 CET: Directory /usr/local/bin/plugins does not exist.

(opencpn:974): Gdk-CRITICAL **: IA__gdk_window_get_origin: assertion `GDK_IS_WINDOW (window)' failed
17:17:01 CET: ChartDB Cache policy: Max open chart limit is 20.
17:17:01 CET: Loading chart db version: V016
17:17:01 CET: Chartdb: Chart directory list follows
17:17:01 CET: Chart directory #0: ../share/opencpn/maps/CM93
17:17:01 CET: GPS Watchdog Timeout is: 6 sec.
17:18:01 CET: LOGBOOK: 2012-02-21 16:18:01 UTC DR Lat 33.35800 Lon -79.28200
17:19:20 CET:
17:19:20 CET: Starting chart database Update...
17:19:20 CET: Error: can't open file '/usr/local/bin/chartlist.dat' (error 13: Permission denied)
17:19:20 CET: Finished chart database Update
17:19:20 CET:
17:19:20 CET: Error: Failed to create a temporary file name (error 13: Permission denied)
17:19:20 CET: Error: can't open user configuration file.
17:19:20 CET: NMEA Data Source is....None
17:19:20 CET: NMEA AutoPilot Port is....None
17:19:20 CET: AIS Data Source is....None
17:19:20 CET: Error: Failed to create a temporary file name (error 13: Permission denied)
17:19:20 CET: Error: can't open user configuration file.

(opencpn:974): Gdk-CRITICAL **: IA__gdk_colormap_alloc_colors: assertion `GDK_IS_COLORMAP (colormap)' failed

(opencpn:974): Gdk-CRITICAL **: IA__gdk_colormap_query_color: assertion `GDK_IS_COLORMAP (colormap)' failed
17:19:29 CET: opencpn::MyFrame exiting cleanly.
17:19:29 CET: Error: Failed to create a temporary file name (error 13: Permission denied)
17:19:29 CET: Error: can't open user configuration file.
17:19:29 CET: Error: Failed to create a temporary file name (error 13: Permission denied)
17:19:29 CET: Error: can't open user configuration file.
17:19:29 CET: LOGBOOK: 2012-02-21 16:19:29 UTC OFF: Lat 33.35800 Lon -79.28200
17:19:29 CET: opencpn::MyApp exiting cleanly...

17:19:29 CET: Error: Failed to create a temporary file name (error 13: Permission denied)
17:19:29 CET: Error: can't open user configuration file.
lasse@storepesen:~$


Starting as su does not give any errors on command line, but still does not find maps.
My version creates config file under .opencpn dir with different name alongside the regular one when started with alternate config.
Rgds
Lasse

[cagney]

It looks like the -p switch on Linux does not work.
After copying all the files and "opencpn" to a directory in my home folder, the program insists on trying to write the user files to /usr/local/bin instead of the directory where "opencpn" is.
Clearly a bug, unless I missed something.........
Thomas

[lurno]

Pavel...
I get your drift about the CTRL-C, so I changed that to CTRL-N (North up).
Below is the resulting patch for toggle Course up.
If this is ok, then more will follow.
Lasse


diff --git a/src/chcanv.cpp b/src/chcanv.cpp
index df39322..cb41f51 100755
--- a/src/chcanv.cpp
+++ b/src/chcanv.cpp
@@ -4163,6 +4163,9 @@ void ChartCanvas::OnKeyDown(wxKeyEvent &event)
break;
}

+ case 14: // Ctrl N
+ parent_frame->ToggleCourseUp();
+ break;
case -32: // Ctrl Space // Drop MOB
{
if ( m_modkeys == wxMOD_CONTROL )
mypatch.diff (END)

[nohal]

Lasse...
Yep, that looks done correctly
Just one note - to keep the formatting when posting code to the forum, wrap it with CODE tags - the '#' symbol in the toolbar, to get it to display like

diff --git a/src/chcanv.cpp b/src/chcanv.cpp
index df39322..cb41f51 100755
--- a/src/chcanv.cpp
+++ b/src/chcanv.cpp
@@ -4163,6 +4163,9 @@ void ChartCanvas::OnKeyDown(wxKeyEvent &event)
                     break;
                }
 
+               case 14:                     // Ctrl N
+                    parent_frame->ToggleCourseUp();
+                    break;
                case -32:                     // Ctrl Space            //    Drop MOB
                {
                     if ( m_modkeys == wxMOD_CONTROL )

Especially if the code is longer, it makes it much more readable and the thread stays reasonably organized. And if you don't mind, please prefer posting patches to OpenCPN's flyspray tracker, although we try hard to pick them up, they sometimes tend to get forgotten here in the forum.

Thanks

Pavel

[cagney]

Originally Posted by cagney

...
Clearly a bug, unless I missed something.........
Thomas

Which I obviously did- It spells "./"
Thomas

[lurno]

Pavel...
Thanks for the tips.
I'll go to the flyspray for more suggestions.
I sort of thought flyspray was bug corrections only.
I'll go there for next suggestions.


Lasse