Development Debugging Environment - Setup Help

[transmitterdan]

Originally Posted by rgleason

It builds release and debug versions from the command line without errors.
So it must be something I am not doing properly in MS Visual Studio.

Rick,

Impossible to build from inside Visual Studio as of now. Always build from command line and debug from VS should work. But it appears you are no longer using the scripts I wrote so hard to tell exactly what you are trying to do.

[rgleason]

TDan. Thanks, that's helpful. I had to upgrade to wxWidgets 3.1.2 a little while ago, so I lost the BATCH setup. I will implement that next.

[Douwe Fokkema]

Error compiling, and solution!

After doing a fresh Windows 10 install on a new computer, I installed the OpenCPN development environment, strictly following the instructions, I know it will work immediately then.

But on the command:

cmake --build . --config release I had the following error, after compiling the sources:
C:\Users\Douwe : general error c1010070: Failed to load and parse the manifest. The system cannot find the file specified. [C:\opencpn\OpenCPN\build\opencpn.vcxproj]
This really puzzled me, the opencpn.vcxproj file is there and all permissions are set.

Searching with Microsoft, the problem seems to be that there is a space in the filename. But in this case there is no space. And still there is a space, it is in the username that Microsoft requires when installing windows. Microsoft asks for your name and makes that the username for the login. Solution: make a new username with a new Microsoft account. Making a new local username will not work (I tried, but the account is still linked to the original name). So this requires a new email address and new Microsoft account. Alternatively you have to reinstall windows. This problem is known in Microsoft for years, they don't do anything with it and they allow spaces in usernames.

May be mention this in the installation manual, Windows username should not have a space in it.
Douwe Fokkema

[Douwe Fokkema]

Another point of interest, compile time.

On my previous I7 based machine time for a full compile of OpenCPN was around 10 minutes. With the new AMD Ryzen 5 3600, this was down to about 5 minutes. Should be faster, not all cores were being used.

Changing following line in the CMakeCache.txt does the job:
//Flags used by the CXX compiler during all build types.
CMAKE_CXX_FLAGS:STRING=/DWIN32 /D_WINDOWS /W3 /GR /EHsc /MP
Here I have added the /MP flag.
Now 11 of the 12 processor threads are fully loaded during a compile, compile time (full compile) is down to 1 minute 35 sec.

But in the fresh Windows installation, this flag is of less importance, without flag 2.5 minute, with /MP 1 min 35 sec.

Douwe Fokkema

[hasse_A]

I am setting up a new environment on windows 10 machine.
Configuration:
VS2017
wxWidgets 3.1.2
I am using Transmitter Dan's batchutils.
Making a release and installing that runs fine.
If l I try to do debugging in VS. I get a trap in wxWidget file appbase.cpp:1163 Red line.


// default assert handler
static void
wxDefaultAssertHandler(const wxString& file,
int line,
const wxString& func,
const wxString& cond,
const wxString& msg)
{
// If this option is set, we should abort immediately when assert happens.
if ( wxSystemOptions::GetOptionInt("exit-on-assert") )
wxAbort();

// FIXME MT-unsafe
static int s_bInAssert = 0;

wxRecursionGuard guard(s_bInAssert);
if ( guard.IsInside() )
{
// can't use assert here to avoid infinite loops, so just trap
wxTrap();

return;
}


If I ignore and do continue I will get a new error in object.cpp:353 Red line
"unable to read data"

void wxObject::Ref(const wxObject& clone)
{
// nothing to be done
if (m_refData == clone.m_refData)
return;

// delete reference to old data
UnRef();

// reference new data
if ( clone.m_refData )
{
m_refData = clone.m_refData;
m_refData->IncRef();
}
}

/Hans

[transmitterdan]

Originally Posted by hasse_A

I am setting up a new environment on windows 10 machine.
Configuration:
VS2017
wxWidgets 3.1.2
I am using Transmitter Dan's batchutils.
Making a release and installing that runs fine.
If l I try to do debugging in VS. I get a trap in wxWidget file appbase.cpp:1163 Red line.


// default assert handler
static void
wxDefaultAssertHandler(const wxString& file,
int line,
const wxString& func,
const wxString& cond,
const wxString& msg)
{
// If this option is set, we should abort immediately when assert happens.
if ( wxSystemOptions::GetOptionInt("exit-on-assert") )
wxAbort();

// FIXME MT-unsafe
static int s_bInAssert = 0;

wxRecursionGuard guard(s_bInAssert);
if ( guard.IsInside() )
{
// can't use assert here to avoid infinite loops, so just trap
wxTrap();

return;
}


If I ignore and do continue I will get a new error in object.cpp:353 Red line
"unable to read data"

void wxObject::Ref(const wxObject& clone)
{
// nothing to be done
if (m_refData == clone.m_refData)
return;

// delete reference to old data
UnRef();

// reference new data
if ( clone.m_refData )
{
m_refData = clone.m_refData;
m_refData->IncRef();
}
}

/Hans

Hans,

Look at the call stack to see what in O is making this call. The problem is likely not within wxWidgets.

[hasse_A]

Thanks Dan!

There is a call from chcanv.cpp: 4354

*r = wxPoint(wxRound(p.m_x), wxRound(p.m_y));

where the values of p seems to be suspicious. Right ?

[transmitterdan]

Originally Posted by hasse_A

Thanks Dan!

There is a call from chcanv.cpp: 4354

*r = wxPoint(wxRound(p.m_x), wxRound(p.m_y));

where the values of p seems to be suspicious. Right ?

Yes, it looks to be an uninitialized value. Now, the challenge is to find out why.

When debugging in Windows it is always a challenge to be sure all the data files are correctly copied into the debug directory tree. With the batch_utils this is done by the config.bat process. Be sure you have the latest batch_utils by doing git pull. The in the O build folder run config.bat and dbbuild.bat. Then start OpenCPN.sln. Don’t try to build inside the Visual Studio IDE. Always use dbbuild.bat.

[hasse_A]

C:\Users\hasse\Sources\BatchUTILS>git pull
Already up to date.

After dbbuild I get the same result with Trap.....

I then did a clean, git pull in the OpenCPN-dir

C:\Users\hasse\Sources\BatchUTILS>git pull
Already up to date.

Did config, dbbuild.bat, started VS and then got the same result.

Should I traverse the call stack upwards to try to find out if p is
set somewhere ?

/Hans

[bdbcat]

Hans...


"p" is set immediately above, at line 4345.
Check the parameters to the GetDoubleCanvasPixPointVP() call.



Dave

[transmitterdan]

Originally Posted by hasse_A

C:\Users\hasse\Sources\BatchUTILS>git pull
Already up to date.

After dbbuild I get the same result with Trap.....

I then did a clean, git pull in the OpenCPN-dir

C:\Users\hasse\Sources\BatchUTILS>git pull
Already up to date.

Did config, dbbuild.bat, started VS and then got the same result.

Should I traverse the call stack upwards to try to find out if p is
set somewhere ?

/Hans

Hans, be sure batch_utils is up to date via git pull in the batch_utils folder.

[hasse_A]

Originally Posted by transmitterdan

Hans, be sure batch_utils is up to date via git pull in the batch_utils folder.

I did this and got "Already up to date."
C:\Users\hasse\Sources\BatchUTILS>git pull
Already up to date.

/Hans

[hasse_A]

Originally Posted by bdbcat

Hans...
"p" is set immediately above, at line 4345.
Check the parameters to the GetDoubleCanvasPixPointVP() call
Dave

Dave,

I attached 2 pictures.
1) values from variables at line 4345
2) values of variables in: void ChartCanvas::ScaleBarDraw( ocpnDC& dc )
which seem to be executed before where the Trap occurs.
The variable m_canvas_height seem to have a large negative value.

/Hans

[hasse_A]

I can't find the place where "m_canvas_height" is set.

A bit surprising is that the value is changed from 998032515 to -842150451
between the breakpoints in the 2 pictures attached.
I can't see any code that is able to do that here.

Only place I can see that the m_canvas_height could be altered is in
chcanv.cpp:6558 GetClientSize( &m_canvas_width, &m_canvas_height );
but that line is never executed before the trap occurred and I am not able to find the function :GetClientSize() anywhere in the src tree.

[transmitterdan]

In Visual Studio you can right click on a function name and then find the source code via that popup menu. You can open the declaration or the implementation of the function.