OpenCPN Beta Version 3.3.1824 Released

[bdbcat]

jp...

The little video "test.exe" did not work right. I see blank screen, with a little mouse movement recorded. No OPCN image at all.

Dave

[bdbcat]

jp...

Very strange that you do not have "Break all" option in debug screen.

Try this:
1. Start O in debug mode, running normal OK.
2. Switch to VS2010 application.
3. Try to find "Debug->Break all" option in Debug menu.
4. Hit "Break all" menu option, and see the break, just to confirm that this works.

Dave

[Ptizef]

Dave

sorry for the video . I think renaming to .pdf has broken it . I will try to do better

At last I got the right menus in VS2010 (Advanced parameters instead of basic parameters )
So I can post attached the call stack at the debug mode O freezing
Curiously I get two types of call stack
Pile-1 & Pile-2 got with the mouse clicks
Pile-3 & Pile-4 got with the finger touches

My process is even more simple . Clicking/touching a route point to highlight the route in yellow then selecting a track (I have severals in the area )
I noticed it don't react everywhere along a track, but I found a place where it freeze for every track

Jean Pierre

[Ptizef]

Dave

I seem to me that a node->GetNext() is missing in chcanv.cpp:6543 to 6552 ?

Jean Pierre

[bdbcat]

jp...

Bingo! You found it!

Now that we see it, it is easy to reproduce.
1. Make a route, and then hide it using route manager dialog.
2. Remember where the route is, say by having it cross a grid line intersection.
3. Make another route, and highlight a route point so that it goes yellow.
4. Click anywhere on the hidden route, i.e. at the grid intersection.
5. Instant hang.

Solution is as you propose. Make the following change:

                if(!b_start_rollover && !b_startedit_route){
                    SelectableItemList SelList = pSelect->FindSelectionList( m_cursor_lat, m_cursor_lon,
                                                                             SELTYPE_ROUTESEGMENT );
                    wxSelectableItemListNode *node = SelList.GetFirst();
                    while( node ) {
                        SelectItem *pFindSel = node->GetData();
                        
                        Route *pr = (Route *) pFindSel->m_pData3;        
                        
                        if( pr && pr->IsVisible() ){
                            b_start_rollover = true;
                            break;
                        }
++                        node = node->GetNext();
                    }       // while
                }

There, now, that wasn't so hard after all. We'll turn you into a developer yet

Thanks, and keep up the good work.
Dave

[Ptizef]

Dave

Now I would focus on points when using touch screen :

When touching a route point to select it, the entire route turns yellow
Now, if you double touch on any other route point (or elsewhere), you will open this first touched point properties dialog. This could be a bit confusing

May be there is a motive to highlight the entire route that I don't see but I would propose to highlight only the selected route point and limit the double touch on this point selection area to open properties ?

also when the route point is selected (thus the route is yellow), and you try to drag it, and you have a bit to slow finger, it can be interpreted as a long touch, opening the point menu. So, a clumsy finger (as mine ) can unintentionally launch a menu command instead of dragging the point
I would propose if possible to deactivate double touch on this point when it is selected and highlighted

the scenario then could be .
one single touch on a route point to select it : it turns yellow
now it it only possible to drag it
a single touch elsewhere suppress selection and yellow highlight
a double touch elsewhere suppress selection and yellow highlight and eventually does a normal action at the place when it is done
a long touch on a no selected route point open his properties dialog
a long touch on a selected route point does nothing

The scenario should be exactly the same for an individual way point


Another point is when creating a route and you want to put a point outside the screen. it's impossible to drag, each touch creating a point.
I don't know how to do that . May be by having a small zone around the screen where a touch would not create a point but drag (as the little green arrows in no touch screen mode ) ?

Jean Pierre

[rgleason]

Build succeeded.
"C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\ALL_BUILD.vcxproj" (default target) (1) ->
"C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\S57ENC.vcxproj" (default target) (6) ->
(ClCompile target) ->
  ..\src\s52plib.cpp(380): warning C4305: '=' : truncation from 'double' to 'float' [C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\S57ENC.vcxproj]
"C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\ALL_BUILD.vcxproj" (default target) (1) ->
"C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\plugin\dashboard_pi\dashboard_pi.vcxproj" (default target) (8) ->
"C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\opencpn.vcxproj"(default target) (10) ->
  ..\src\Route.cpp(656): warning C4305: 'initializing' : truncation from 'double' to 'float' [C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\opencpn.vcxproj]

  ..\src\Route.cpp(665): warning C4305: '-=' : truncation from 'double' to 'float' [C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\opencpn.vcxproj]
  c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\include\math.h(632): warning C4005: 'M_PI' : macro redefinition [C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\opencpn.vcxproj]
4 Warning(s)   0 Error(s)

[Ptizef]

I found a problem with routes and route points creation :

1) create a route then delete it, exit and restart O : all the route point are still here and in the way point list in the route manager

2) create a route then exit and restart O
there are now two routes in the route manager and all the route points are in the way point list
delete both and the points are still in the route manager

the version is compiled from git including the commit "Correct sounding render inclusion test. " this morning

Jean Pierre

[rgleason]

Build succeeded.

"C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\ALL_BUILD.vcxproj" (default target) (1) ->
"C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\S57ENC.vcxproj" (default target) (6) ->
(ClCompile target) ->
  ..\src\s52plib.cpp(380): warning C4305: '=' : truncation from 'double' to 'float' [C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\S57ENC.vcxproj]


"C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\ALL_BUILD.vcxproj" (default target) (1) ->
"C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\plugins\dashboard_pi\dashboard_pi.vcxproj" (default target) (8) ->
"C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\opencpn.vcxproj" (default target) (10) ->
  ..\src\Route.cpp(656): warning C4305: 'initializing' : truncation from 'double' to 'float' [C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\opencpn.vcxproj]

  ..\src\Route.cpp(665): warning C4305: '-=' : truncation from 'double' to 'float' [C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\opencpn.vcxproj]
  ..\src\ais.cpp(752): warning C4305: '=' : truncation from 'double' to 'float'
[C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\opencpn.vcxproj]
  ..\src\ais.cpp(754): warning C4305: '=' : truncation from 'double' to 'float'
[C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\opencpn.vcxproj]
  ..\src\ais.cpp(756): warning C4305: '=' : truncation from 'double' to 'float'
[C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\opencpn.vcxproj]
  ..\src\ais.cpp(996): warning C4305: '+=' : truncation from 'double' to 'float'
 [C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\opencpn.vcxproj]
  ..\src\ais.cpp(998): warning C4305: '-=' : truncation from 'double' to 'float'
 [C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\opencpn.vcxproj]
  c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\include\math.h(632): warning C4005: 'M_PI' : macro redefinition [C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\opencpn.vcxproj]
    9 Warning(s)
    0 Error(s)

[bdbcat]

jp...

Regarding your observation about duplicate points in route creation and deletion....

I cannot reproduce this. Is it possible that you have some kind of leftover "changes" file in your config directory?

The changes file should exist while OCPN is running, but should be deleted on a normal shutdown of OCPN.

In normal conditions, there should be no "changes" file in your config directory when you start OCPN.

Are you running in portable mode?

Dave

[Ptizef]

Hi Dave

I run in a "normal" environment, not portable.

Yes I have a "change" file on both my two computers reproducing the problem

Without this file, it works fine

Creating, deleting routes and WPts and track do not keep such a file any more
On this two machines I have tested the "crash and track rescue" . I suppose these files have been kept at this occasion ?

Jean Pierre

[bdbcat]

jp...

I can now reproduce the problem if I cause a crash, so that there is an unprocessed "changes" file on the next startup. This is a problem with ingesting and applying the changes file, should be easy to fix.

However, unless you crash, or stop O from within a debugger, then you should never have a "changes" file to apply on startup of O.


Lets please confirm that, for you, when you shut down O normally, there is no "changes" file left in the config directory.

Dave

[Ptizef]

Originally Posted by bdbcat

However, unless you crash, or stop O from within a debugger, then you should never have a "changes" file to apply on startup of O.
Lets please confirm that, for you, when you shut down O normally, there is no "changes" file left in the config directory.
Dave

I can confirm : No "change" file left when O is closed normally

Jean Pierre

[bdbcat]

jp...

I made some changes to the Touch screen interface, mainly following your thoughtful suggestions.

1. A RoutePoint or mark is highlighted by single touch.
2. While highlighted, mark is able to be moved.
3. Single or double click away from mark de-selects the mark for moving.
4. While a point is selected and hilighted, the long touch has no effect.
5. While drag-moving a point, if you move to near the screen edges, the chart will pan as long as the touch is held in this margin.

6. In route creation, the route being created is highlighted as a reminder of what mode you are in. We do this because there is no mouse cursor on a touch tablet.
7. While creating a route, if you touch near the edges of the screen, the chart will pan and no point will be added. Also, the zoom in/out buttons on the toolbar work during route creation.

All of this is in github now. I look forward to your comments.

Thanks
Dave

[Ptizef]

Hi Dave

Compiled and tested new Git
The new scenario to move Wpts and route points and to create routes works fine.
From my test I found it very easy now . Many thanks
Just a small detail. I can highlight several route points. The last touched point is the selected one but the others previously touched stay highlighted until I re-select then unselect it. This don't happen with individual Wpts.
To reproduce, start with a route and touch more than one point one after one. If you touch an individual wpt first it will not happen any more
Jean Pierre