Tactics Plugin

[RonSouthworth]

[QUOTE=rgleason;2885166]

Your release tab for Opencpn5 is here
https://github.com/scadaperspective/OpenCPN5/releases

/QUOTE]

Hi Rick,

I spent only a couple of moments out of a busy day full of interruptions

glad to amend the structure and upload as suggested.

Will respond to the direct message once I am “in the office”

Will download the commit from efforts today and test

[RonSouthworth]

[QUOTE=rgleason;2885166]

Your release tab for Opencpn5 is here
https://github.com/scadaperspective/OpenCPN5/releases

/QUOTE]

Hi Rick,

I spent only a couple of moments out of a busy day full of interruptions

glad to amend the structure and upload as suggested.

Will respond to the direct message once I am “in the office” my phone and pop ups not so happy together

Will download the commit from Canne’s efforts today and test

/Ron

[rgleason]

Learned how to resolve conflicts inside your remote github account for PR trying to merge with conflicts, using the webapp, pretty easy.


It built and it works seems to be working better than the ov42 version even, 2.5% cpu use. For those testing, it is here https://ci.appveyor.com/project/rgle...7033/artifacts Don't forget to label it "-ov50" please!


Please advise regarding testing, when I get confirmations I will make a new release unless there is something else that comes up.


Thank you Canne.

[rgleason]

Great, Ron, the appveyor compiled ov50 version of Canne's is here
https://ci.appveyor.com/project/rgle...7033/artifacts
if it will save you some trouble.



[QUOTE=RonSouthworth;2885479]

Originally Posted by rgleason

Your release tab for Opencpn5 is here
https://github.com/scadaperspective/OpenCPN5/releases

/QUOTE]

Hi Rick,

I spent only a couple of moments out of a busy day full of interruptions

glad to amend the structure and upload as suggested.

Will respond to the direct message once I am “in the office” my phone and pop ups not so happy together

Will download the commit from Canne’s efforts today and test

/Ron

[RonSouthworth]

Thanks Rick & Canne,

moved packages to the release directory, easier to grab Canne's commit directly which I have,

I will install and test on my linux box as well...

Thanks all round

/Ron

[rgleason]

[QUOTE=RonSouthworth;2885479]

Originally Posted by rgleason

Your release tab for Opencpn5 is here
https://github.com/scadaperspective/OpenCPN5/releases

/QUOTE]

Hi Rick,

I spent only a couple of moments out of a busy day full of interruptions

glad to amend the structure and upload as suggested.

Will respond to the direct message once I am “in the office” my phone and pop ups not so happy together

Will download the commit from Canne’s efforts today and test

/Ron

Sorry, forgot you're a different OS!

[RonSouthworth]

[QUOTE=rgleason;2885529]

Originally Posted by RonSouthworth

Sorry, forgot you're a different OS!

All OK

Compiled on macOS

Other differences are in the #30 changes....

Not sluggish at all

Layline seem to be thin ?

/Ron

[RonSouthworth]

Hi

Laylines are ok after some extended dynamic testing.

/Ron

[rgleason]

Agreed about the layline. I don't believe that is accessible.

[transmitterdan]

Lay lines require OpenGL else they will not be rendered.

[rgleason]

Originally Posted by transmitterdan

Lay lines require OpenGL else they will not be rendered.

Yes, Ron thinks and I agree, that the laylines are to narrow.


TDan, you had some great ideas about how Dashboard could be reworked and improved and I have not been able to find that discussion. I believe it was a discussion, so it must be in the forums, most likely this thread, but my searches don't turn it up. I do know that one of the issues was that Tactics had appeared which is based on Dashboard.


Do you know where to find that discussion? Or have some suggestions where to look?


I found it! http://www.cruisersforum.com/forums/...ml#post2112580

[Canne]

Rick,
Thanks for testing my Dashboard porting branch of Tactics_pi!

Originally Posted by rgleason

Are you able to meld Tactics and Dashboard?

Unfortunately, I am too busy professionally. But I gave it a thought while porting the changes "the wrong way": IMO the best approach would be to import the four main Tactics_pi functions into Dashboard plugin. Not that big task - polarcompass.cpp, bearingcompass.cpp, performance.cpp, avg_wind.cpp: class tactics.cpp (ex. tactics_pi.cpp) would be the carrier for those. It would be instantiated only if "Dashboard performance mode" or similar would be selected, in which case boat's polar file would be asked to feed tactics.

Tom-r's great work would deserve to go into the main O distribution! (Did I mention that I am a performance freak? )

Originally Posted by rgleason

Why don't you make a PR to Thomas with these improvements?

Please wait until I get back to my boat: I will test with USB and TCP/IP connected instruments first (including a barometer of which I don't have a recording). If you can wait for a few days I'll merge my test branch to trunk, rebuild, test and make a PR to Tom-r this weekend.

[RonSouthworth]

Hi Gents,

What I am observing on macOS from overnight testing with Canne's present version is the laylines on the chart appear to be less than the initial value set in the configuration preferences on startup.

The laylines on the instruments don't appear to be impacted.

The lines minimum width on the chart does not appear change when you alter this value in preferences.

The simulation software I am using varies the wind values about a set-point based on a random number at or about +/- 20% with about 2-4 hours the width does increase and decrease consistent to previous versions so after a while they become more like what you are use to...

I can fast track making the width increase by simulating two instrument sources sending data of varying wind speeds and directions. The width seems to stay to a value based upon the variance of the wind thereafter until restart.

Based on this observation alone It might be something to do with initialisation / reading the minimum value of the width ??

I will test on my slow linux box and advise if there is any difference from this.

I can only look at one trend at a time without making things run too slow on the linux box, I have had some crashing on my macOS however I am testing a lot of different things so the instability is most likely one of the more troublesome plugins as it is quite sturdy with the set that are performing reliably.

/Ron

[RonSouthworth]

Ive confirmed that linux doesn't have a problem (causing a crash) if you don't delete the tactic's temporary mark before shutdown / restart.

Can someone confirm if windows is ok as well..?


Thanks

/Ron.

[rgleason]

Ron Tactics was programmed in Windows, so it works. I've just checked and can make and set tactics mark and delete it with impunity. No crash. We must be missing some small closing or something that Linux expects. Can you trace it?