Cruisers Forum
 

Go Back   Cruisers & Sailing Forums > Seamanship, Navigation & Boat Handling > OpenCPN
Cruiser Wiki Click Here to Login
Register Vendors FAQ Community Calendar Today's Posts Log in

Reply
  This discussion is proudly sponsored by:
Please support our sponsors and let them know you heard about their products on Cruisers Forums. Advertise Here
 
Thread Tools Search this Thread Rate Thread Display Modes
Old 20-06-2012, 00:53   #1
Registered User
 
globalkeith's Avatar

Join Date: Sep 2010
Location: Zhuhai, China
Boat: Prout G55
Posts: 76
v3.0 Changes required for third party plugins

Can anyone show me what I need to change in my plugin to support the new toolbar?

Also still not getting the demo_pi working in v3.0, should this be working?

thanks
Keith
globalkeith is offline   Reply With Quote
Old 20-06-2012, 04:42   #2
Registered User

Join Date: Dec 2008
Boat: Journeyman
Posts: 705
Re: v3.0 Changes required for third party plugins

Quote:
Originally Posted by globalkeith View Post
Can anyone show me what I need to change in my plugin to support the new toolbar?
Let's get this right:

v3.0 does NOT have a new toolbar.

v3.2 (to be released in the fall) will eventually have a new toolbar, which will debut in v3.1Betas. This is under development and the plugin API for styling is not yet decided.

/j
JesperWe is offline   Reply With Quote
Old 20-06-2012, 13:24   #3
Registered User
 
globalkeith's Avatar

Join Date: Sep 2010
Location: Zhuhai, China
Boat: Prout G55
Posts: 76
Re: v3.0 Changes required for third party plugins

Hi Jesper,

I apologise for my faux pas - I didn't mean to stir up trouble - let me rephrase.

I have recently merged my local git repository with upstream master, and now the icon for my plugin fails to show the image, instead showing a crazy pattern:

Click image for larger version

Name:	Screenshot from 2012-06-20 10:18:35.png
Views:	150
Size:	76.7 KB
ID:	42560

All I'm asking is what changes do I need to make to my plugin code to work with the new skins - as you can see from the screenshot, what I have right now, which worked prior to updating, doesn't work as expected.

thanks
Keith
globalkeith is offline   Reply With Quote
Old 20-06-2012, 13:56   #4
Registered User
 
globalkeith's Avatar

Join Date: Sep 2010
Location: Zhuhai, China
Boat: Prout G55
Posts: 76
Re: v3.0 Changes required for third party plugins

Hi Jesper,

this is what I'm talking about....

thanks
keith
globalkeith is offline   Reply With Quote
Old 20-06-2012, 14:57   #5
Registered User

Join Date: Dec 2005
Location: Helsingborg
Boat: Dufour 35
Posts: 3,891
Re: v3.0 Changes required for third party plugins

Keith

The "upstream master" in your case (GitHub) is still alpha code, not any release or beta code, even though it's called "master" and the version has not been changed.
The real 3.0 master is still in git on Sourceforge. This may change later.
You will have to wait a while, until the final "skin" API is decided.

Thomas
cagney is offline   Reply With Quote
Old 20-06-2012, 16:09   #6
Registered User

Join Date: Dec 2008
Boat: Journeyman
Posts: 705
Re: v3.0 Changes required for third party plugins

Just to re-empathize, the Github master branch is our development code sharing repo. OpenCPN is an open project, and you are absolutely free to build from that if you want. But expect all sorts of crazy things to happen, including crashes, your computer freezing and big hairy monsters eating your hard disk. In real life this means: Don't do it, unless you are involved in the current development phase (to which you and everyone else are very welcome, of course, if you can and want to contribute!)

If you want to build stuff that has been somewhat tested and has a higher chance of actually working, build from the release branches/tags. (Right now this means 3.0.0 as no 3.1 beta has yet been tagged)

And BTW, if you want your plugins to work with current master, you can check the code how it is done for dashboard and grib, and change them the same way. But that way will change in the coming few days, and you will have to change again. That's life on the development edge..!
JesperWe is offline   Reply With Quote
Old 20-06-2012, 16:21   #7
Registered User
 
globalkeith's Avatar

Join Date: Sep 2010
Location: Zhuhai, China
Boat: Prout G55
Posts: 76
Re: v3.0 Changes required for third party plugins

Hi Jesper,

Thanks, I was really hoping for a summary of what changes to dashboard/grib were necessary to get it working in the current master. I'll go figure it out myself.

ps - I'm well aware of development process - as an open source project it would help all developers enormously if we all can collaborate.

cheers
Keith
globalkeith is offline   Reply With Quote
Old 20-06-2012, 16:23   #8
Registered User
 
globalkeith's Avatar

Join Date: Sep 2010
Location: Zhuhai, China
Boat: Prout G55
Posts: 76
Re: v3.0 Changes required for third party plugins

Quote:
Originally Posted by cagney View Post
Keith

The real 3.0 master is still in git on Sourceforge. This may change later.

Thomas
+1 for that!
globalkeith is offline   Reply With Quote
Old 20-06-2012, 16:58   #9
Registered User

Join Date: Dec 2008
Boat: Journeyman
Posts: 705
Re: v3.0 Changes required for third party plugins

Quote:
Originally Posted by globalkeith View Post
Thanks, I was really hoping for a summary of what changes to dashboard/grib were necessary to get it working in the current master. I'll go figure it out myself.
Well, as it stands you need to put a tool name in the "label" field of InsertPluginTool(), and then match that name on a <tool> tag in styles.xml, and draw the corresponding icons in the PNG.

This way of doing it is not good, just a stop-gap, and I'm right now gathering feedback from Pavel and J-E as major plugin developers on how to do it right.

The target is to allow the plugin to have it's own icons, but also allow the style to override them if it knows about the plugin.
JesperWe is offline   Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are Off
Pingbacks are Off
Refbacks are Off


Advertise Here


All times are GMT -7. The time now is 10:37.


Google+
Powered by vBulletin® Version 3.8.8 Beta 1
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Social Knowledge Networks
Powered by vBulletin® Version 3.8.8 Beta 1
Copyright ©2000 - 2024, vBulletin Solutions, Inc.

ShowCase vBulletin Plugins by Drive Thru Online, Inc.