VDR 1.2.6 Raspberry Pi Record Dialog Box issue

[ZagsAtCF]

Hi,

I have VDR 1.2.6 installed on a Raspberry Pi 3. When I click on the VDR record button it brings up the play open file dialog box instead of the new file dialog box.

Thank you.

[cagney]

Same on Linux.
This was correct in version 1.2.3.

[sv_pelagia]

When I record, I toobget the open file (rather than save as) box as well on aandroid and PC. Fortunately, it functions as "save as".

[rgleason]

Perhaps one of you sharp eyed raspberry programmers can spot the change since June 12 in one of the commits, and advise us where the problem is. I can't find any material change to that part of the program.



https://github.com/rgleason/vdr_pi/commits/master

[cagney]

I think that the problem must be in this commit:

Improve to use platform optimized file dialog.
@bdbcat
bdbcat committed on Sep 8

Thomas

[rgleason]

Thanks, I see that, but don't know what to change
https://github.com/rgleason/vdr_pi/c...1a16fd937fb092


Why would these changes result in the "save as" instead of Open?

[stevead]

Because the code has been changed from using wxWidgets wxFileDialog functions to an OpenCPN provided PlatformFileSelectorDialog.

wxFileDialog fdlg( GetOCPNCanvasWindow(), _("Choose a file"), wxT(""), m_ifilename, wxT("*.*"), wxFD_OPEN|wxFD_FILE_MUST_EXIST );

and

wxFileDialog fdlg( GetOCPNCanvasWindow(), _("Choose a file"), wxT(""), m_ofilename, wxT("*.*"), wxFD_SAVE|wxFD_OVERWRITE_PROMPT );

to

int response = PlatformFileSelectorDialog( GetOCPNCanvasWindow(), &file, _("Choose a file"), idir, ifile, _T("*.*") );

and without looking at the OpenCPN code to find the implementation of PlatformSelectorDialog, who knows whether it is a File Open or File Close dialog?
Simple fix, revert the changes.

[rgleason]

stevead, Thanks, that is helpful but I believe bdbcat did that to fix issues in Android, so reverting is not an option, it needs to be fixed.


C:\Users\Rick\Documents\GitHub\OpenCPN\src\pluginm anager.cpp (1 hit)
Line 8297: int PlatformFileSelectorDialog( wxWindow *parent, wxString *file_spec, wxString Title, wxString initDir,

https://github.com/OpenCPN/OpenCPN/b...ginmanager.cpp

int PlatformDirSelectorDialog( wxWindow *parent, wxString *file_spec, wxString Title, wxString initDir)
{
return g_Platform->DoDirSelectorDialog( parent, file_spec, Title, initDir);
}

int PlatformFileSelectorDialog( wxWindow *parent, wxString *file_spec, wxString Title, wxString initDir,
wxString suggestedName, wxString wildcard)
{
return g_Platform->DoFileSelectorDialog( parent, file_spec, Title, initDir,
suggestedName, wildcard);
}

[stevead]

Hi Rick,

OK, understand that it was done for some obscure reason that mere minions like us are not privy to.

However the problem lies in the fact that the PlatformFileSelectorDialog API does not appear to have any arguments that differentiate between a file open or file save dialog.

Perhaps it was not designed for the purpose that you are using it for in the VDR plugin?

Good luck.

[rgleason]

Steve, you are probably right about reverting, but I wouldn't know. I guess I'll ask Dave directly. Thanks for your help.

Originally Posted by stevead

Hi Rick,

OK, understand that it was done for some obscure reason that mere minions like us are not privy to.

However the problem lies in the fact that the PlatformFileSelectorDialog API does not appear to have any arguments that differentiate between a file open or file save dialog.

Perhaps it was not designed for the purpose that you are using it for in the VDR plugin?

Good luck.

[rgleason]

I think this report can be ignored. Can anyone else please test and report exactly what the problem is? Is it really a bug? Is it repeatable?

I tested VDR on Windows and it works just as I expected.

[bcn]

Rick,


just tested the updated 1.2.6 under macOS and "recording" brings up a dialogue to select an existing file - not to define a file for output, where you are able to edit the name for example.


Hubert

[rgleason]

bcn,
The menu does not show "Choose a file" and have "Save" at the bottom right?
I can put a new filename in and pick "Save" and it records to the new file.

[bdbcat]

Rick...
I corrected the source in github. Now at 1.2.7.
Builds fine in cloudsmith vdr-beta repo.
I guess it needs to be tagged and rebuilt into cloudsmith vdr-prod, and then update the plugin master catalog.
Will you do this?


Thanks
Dave

[rgleason]

Thank you Dave. I would be delighted to follow through on this.