Watchdog Plugin

[Baikal]

Originally Posted by Roel Smidt

I have been working on the Watchdog documentation.
If there's anything you think I should add, change or delete, feel free to bark at me! (Just don't bite please...).

Roel

excellent work!

[Hakan]

Roel..
You really have been working and the result is both very informative and enjoyable. No barks but lots of tail wagging.
Håkan

[jongough]

Roel,
Looking good. The dialog panel at step 4 (S-WDpi-21, S-WDpi-32, etc as well) has changed, it now is a vertical list as the horizontal one was not displaying properly on all devices. I hope the vertical one will.

In the Boundary alarm section you show the OD toolbar twice showing the same thing, I think you want to show Boundary and Boundary Point.

But this does explain how the WD works and gives good examples. Thanks very much!

Regards
Jon

[ptulp]

Originally Posted by Roel Smidt

I have been working on the Watchdog documentation.
If there's anything you think I should add, change or delete, feel free to bark at me! (Just don't bite please...).

Roel

Roel,

There are a few problems with links.
In the contents the alarm links (like Landfall Alarm) are linked to the extensive descriptions (eg LANDFALL ALARM ) in the html version.
For the export version however, as the link name is "Landfall Alarm"
it will link to the header with this text, which is the small description in the
Standard Action part.
If you want to link the contents to the extensive part in the export version
you have to name the link with the capital name LANDFALL ALARM or the export php code will not link it properly.

Regards,
Peter

[Roel Smidt]

Jon, thx. I corrected those pics. Something else though. I suspect a bug in the WD Speed Alarm. When I set a speed and activate the alarm, I think WD only sees my own speed and not the set speed. Testing the speed alarm is a bit difficult as I have OpenCPN only on my Desktop-PC at home (and the speed of my house is -and should stay- somewhere around 0.0 knots).

Can anyone confirm that bug or is the problem on my side?

See the enclosed doc.

Roel

[Roel Smidt]

Peter, thanks.
I will look into this day after tomorrow. But I am a newbie at HTML and do not really understand what I have done or should do to fix it. Maybe I will need some help in Dutch.

Vriendelijke groet,
Roel

[ptulp]

Originally Posted by Roel Smidt

Peter, thanks.
I will look into this day after tomorrow. But I am a newbie at HTML and do not really understand what I have done or should do to fix it. Maybe I will need some help in Dutch.

Vriendelijke groet,
Roel

Roel,

The question is where you want the Contents links pointing to:

To the extended description or the short description?

Peter

[ptulp]

Originally Posted by Roel Smidt

Jon, thx. I corrected those pics. Something else though. I suspect a bug in the WD Speed Alarm. When I set a speed and activate the alarm, I think WD only sees my own speed and not the set speed. Testing the speed alarm is a bit difficult as I have OpenCPN only on my Desktop-PC at home (and the speed of my house is -and should stay- somewhere around 0.0 knots).

Can anyone confirm that bug or is the problem on my side?

See the enclosed doc.

Roel

I can confirm that there is a bug in the code.

In the Test() function in the file Alarm.cpp for the SpeedAlarm, the test is between the same values, so this can not work.
Also the sog calculation in function watchdog_pi::OnTimer() in file watchdog_pi.cpp is not correct I think.
If using the watchdog plugin with a VDR run, the sog in the dashboard is not the same as shown in the watchdog window.

Peter

[Roel Smidt]

OK, so it's not me. I have put it in Tracker/Flyspray.

[Roel Smidt]

Hi,
I discovered an interesting feature of Watchdog today and updated the Watchdog-document. Have a look at "How can WD alert me".
Roel

[jongough]

Peter,
I have just put up 1.9.020 to try and fix the error. Can you try and see if it works for you.

Thanks
Jon

Originally Posted by ptulp

I can confirm that there is a bug in the code.

In the Test() function in the file Alarm.cpp for the SpeedAlarm, the test is between the same values, so this can not work.
Also the sog calculation in function watchdog_pi::OnTimer() in file watchdog_pi.cpp is not correct I think.
If using the watchdog plugin with a VDR run, the sog in the dashboard is not the same as shown in the watchdog window.

Peter

[Hakan]

Jon, Peter. Watchdog speed alarm
Now the presentation is correct i.e. displays SOG and Limit. And the alarm trig is also correct. But..
Initially Sean tried to filter the used SOG, by m_sog, in order to avoid instant low/high values caused by for example waves. I can't judge the effect of that filter. But "LastFix().Sog" will alarm for every wave if SOG is close to the limit.
We could use m_sog instead like this

private:
    double Knots() {
        if(isnan(g_watchdog_pi->LastFix().Sog)) return 0.;
        else return g_watchdog_pi->m_sog; // g_watchdog_pi->LastFix().Sog;

but there is something wrong with m_sog. The value is sometimes up to 200 Kn.

I'm thinking of some kind of median value of the last 10 SOG's the last 20 seconds or something.
Like this basic example, but corrected in a more prof way.

Median 11 values every other sec.
//decl
float sogdata[];
wxTime? sogtimer = now();
int SOGreadCount = 0;

//20 seconds median SOG value
float Knots(float LastValue)
{ 
    if now() > sogtimer + 2000 {
        if SOGreadCount > 10 {
            sogdata[SOGreadCount] = g_watchdog_pi->LastFix().Sog);
            SOGreadCount = 0;
            sogtimer = now();
            //Sort sogdata
            for (int i = 11; i < 0; --i) {
                for (int j = 0; j < i; ++j) {
                    if (sogdata[j] > sogdata[j+1]) {
                        double dTemp = sogdata[j];
                        sogdata[j] = sogdata[j+1];
                        sogdata[j+1] = dTemp;
                    }
                }
            }
            return sogdata[5];
        } else {
            sogdata[SOGreadCount] = g_watchdog_pi->LastFix().Sog);
            SOGreadCount++;
            sogtimer = now();
        }
    }
    return LastValue
}

[jongough]

Hi,
When working on the fix for this I could not get a stabilised SoG when using the calculations that Sean put in. It was almost as if the time slot was too coarse and the calculated SoG was going between 10 & 200 kn. I did get it to stabilise more, but I had to move the timer to go every 10seconds not 3 that he had. But still, it varied too much.

The changes I have put in are only to show that it works. If someone else wants to try and fine tune that to give a stabilised SoG I would welcome that. I am only really working on the WD plugin to show capability when used with OD. I think there could be much more put into this, but it does take time..... I am much more focused, currently, on sorting out the bugs in OD and making it play correctly with OCPN.

Jon

[Hakan]

Jon
Very good, I do understand.
I could try my idea for you and/or Sean to check.
Håkan

[ptulp]

Originally Posted by jongough

Peter,
I have just put up 1.9.020 to try and fix the error. Can you try and see if it works for you.

Thanks
Jon

Jon,

The fix works, but I found another problem with the saving/loading of the speed alarms. In the LoadConfig function we need the exclamation marks at the strcasecmp and we need a break in the SaveConfig function.

Thanks,
Peter


void LoadConfig(TiXmlElement *e) {
const char *mode = e->Attribute("Mode");
if(!strcasecmp(mode, "Underspeed")) m_Mode = UNDERSPEED;
else if(!strcasecmp(mode, "Overspeed")) m_Mode = OVERSPEED;
else wxLogMessage(_T("Watchdog: ") + wxString(_("invalid Speed mode")) + _T(": ")
+ wxString::FromUTF8(mode));

e->Attribute("Speed", &m_Speed);
}

void SaveConfig(TiXmlElement *c) {
c->SetAttribute("Type", "Speed");
switch(m_Mode) {
case UNDERSPEED: c->SetAttribute("Mode", "Underspeed"); break;
case OVERSPEED: c->SetAttribute("Mode", "Overspeed");
}

c->SetDoubleAttribute("Speed", m_Speed);
}