Weather Routing

[bdbcat]

Sean....
After some more poking around, I have determined the cause of the rendering hang.
A small, silly bug found its way into OCPN 5.6.2. The Plugin API method "GetCanvasPixLL()" will return wxPoint(INVALID_COORD, INVALID_COORD) if the calculated pixel point is too far off screen. This causes the render logic in weather_routing_pi to get confused at large scale rendering.
Fortunately, the API method "GetDoubleCanvasPixLL()" does not have this bug.
So, I built a simple wrapper, to avoid changing wr_pi too much. And it appears to work.

void WR_GetCanvasPixLL(PlugIn_ViewPort *vp, wxPoint *pp, double lat, double lon)
{
    wxPoint2DDouble pix_double;
    GetDoubleCanvasPixLL(vp, &pix_double, lat, lon);
    pp->x = (int)wxRound(pix_double.m_x);
    pp->y = (int)wxRound(pix_double.m_y);
}

I'll have a PR for your repo later today. After you merge, then Rick can pull from upstream, and re-publish the plugin.


Thanks
Dave

[bdbcat]

Sean/Rick....
It was much simpler for me to post a PR to Rick's repo directly.
I have done that.
Sean, you may want to backport from Rick's repo, or Rick can PR upstream. Whichever works best.


Thanks
Dave

[ALROCHARARI]

Originally Posted by hasse_A

It might be a dumb question but I will ask it anyway.
Have you activated the box "Detect Land" under the configuration ?

One other dumb question.
Have you downloaded and installed the High resolution base chart ?

To answer your question: No I have not had problems with this so far.

/Hans

Highest résolution of GSHHG used but still far from perfect.
See video attached to compare with oeuSENC data.
https://www.dropbox.com/s/cblts175gl...38-02.mkv?dl=0

Could it be possible to base WeatherRouting calculations on oeuSENC map?
With the possibility also to specify a safety distance: Nm from ground or depth.

What do you think of this?

Best regards,
Raoul

[ozolli]

Raoul,
Safety margin from land is already implemented in the advanced tab of the weather routing configuration window..

[bdbcat]

"Highest résolution of GSHHG used but still far from perfect."


Could you please show an image with just the GSHHS charts draw, so that we can verify that the land avoidance is actually working correctly for GSHHS?


Thanks
Dave

[seandepagnier]

Originally Posted by ALROCHARARI

Could it be possible to base WeatherRouting calculations on oeuSENC map?
With the possibility also to specify a safety distance: Nm from ground or depth.

What do you think of this?

Best regards,
Raoul

How would the plugin access the depth or contour data? There is no depth function in the plugin api.

How does it know what chart to use if there are several?

[bdbcat]

alrocharari...


Sorry, I did not notice that the posted picture was a video. On looking again, I see that the computed route does indeed obey the "no-land-crossing" specification, at least as determined by GSHHS charts.
As Sean notes, we do not yet have the ability to auto-route according to actual navigation-quality charts, although there has been some discussion about this. The effort is seen as low priority at the moment, but that could change in time.



FWIW, I think you are asking a bit much if you depend on any auto-routing algorithm to operate safely within an archipelago region such as this. My 2 cents...


Dave

[seandepagnier]

Originally Posted by bdbcat

Sean....
After some more poking around, I have determined the cause of the rendering hang.
A small, silly bug found its way into OCPN 5.6.2. The Plugin API method "GetCanvasPixLL()" will return wxPoint(INVALID_COORD, INVALID_COORD) i

I guess this isn't right or wrong.. but wondering why the change was made? it can also break other plugins. In any case, this fix is fine at least for weather routing, thanks!

Originally Posted by bdbcat

alrocharari...

FWIW, I think you are asking a bit much if you depend on any auto-routing algorithm to operate safely within an archipelago region such as this. My 2 cents...

Yes, but it is interesting to note it's suggestions. In any case, it is only so accurate as the data input which is not exact, so weather routing through islands is probably not very accurate anyway as the islands affect wind and currents in ways usually not modeled in the input.

Having access to depth and contours in plugins should be considered. It would also be very useful to make a chart depth alarm for watchdog, but also for a survey plugin.

[ALROCHARARI]

Dave, Sean,

Thanks for your explanations.
Just happy to make suggestions (Even if not always relevant).
Just want to support the great job done so far.

Best regards,
Raoul

[ALROCHARARI]

Originally Posted by ozolli

Raoul,
Safety margin from land is already implemented in the advanced tab of the weather routing configuration window..

Mea culpa maxima culpa
Thanks for clarification. I missed it.

[ALROCHARARI]

Hello guys,

Me again with another suggestion which can be a serious issue on some occasions.

I think this is applicable to all the plugins:

Application keep the position of plugin last position on screen and reopen it at the same position when you activate it again.
Issue for me: Preparing sailing on a big 3840x1080 screen and putting my plugins windows on the right and the opencpn application on the left.

When moving on the boat, I take the laptop with me and activate opencpn and weatherrouting on it. If activating weatherrouting, the window is not visible. Impossible to select it. Only evidence it is open is the icon layout change.

Suggestion: Checking screen situation when reopening the plugins and make them opening on the active screen if previous screen position is no longer relevant.

Hope you will find this one relevant.
Best regards,
Raoul

[rgleason]

Originally Posted by ALROCHARARI

Hello guys,

When moving on the boat, I take the laptop with me and activate opencpn and weatherrouting on it. If activating weatherrouting, the window is not visible. Impossible to select it. Only evidence it is open is the icon layout change.
Raoul

Sometimes we need to depend on the OS to solve these things.


You know alt-tab of course there are other shortcuts
After alt-tab and After you’ve got the window active, Shift+right-click the taskbar button (because just right-clicking will open the app’s jumplist instead) and choose the “Move” command from the context menu.


https://www.howtogeek.com/howto/wind...eyboard-trick/


right-click on the Taskbar and select one of the window arrangement settings, like “Cascade windows” or “Show windows stacked.”


https://www.howtogeek.com/661249/how...on-windows-10/ Go down to "Move a window precisely"

[shipahoy]

Originally Posted by ALROCHARARI

Hello guys,
When moving on the boat, I take the laptop with me and activate opencpn and weatherrouting on it. If activating weatherrouting, the window is not visible. Impossible to select it. Only evidence it is open is the icon layout change.

I have the same issue for many programs on Windows.
My quick fix for Weather Routing is to delete the following from the [PlugIns/WeatherRouting] section of opencpn.ini:
SettingsDialogX=-753
SettingsDialogY=463
DialogX=-1844
DialogY=552
ConfigurationX=-1205
ConfigurationY=269

[Hakan]

Win 10
With version 1.13.44 the zooming hang issue is gone.
Thanks.
Håkan

[ALROCHARARI]

Originally Posted by rgleason

Sometimes we need to depend on the OS to solve these things.


You know alt-tab of course there are other shortcuts
After alt-tab and After you’ve got the window active, Shift+right-click the taskbar button (because just right-clicking will open the app’s jumplist instead) and choose the “Move” command from the context menu.


https://www.howtogeek.com/howto/wind...eyboard-trick/


right-click on the Taskbar and select one of the window arrangement settings, like “Cascade windows” or “Show windows stacked.”


https://www.howtogeek.com/661249/how...on-windows-10/ Go down to "Move a window precisely"

Not working on Windows 11. I don't know how to solve it. (Just connected my big screen again and paid attention to keep my windows on the left before closing. Not ideal...)

I confirm that the zooming bug is fixed with latest release of the plugin on W11.
Great job guys.

Best regards,
Raoul